[heap] Restore original heap size#371
Open
IlyasShabi wants to merge 1 commit into
Open
Conversation
IlyasShabi
changed the title
Overall package sizeSelf size: 2.41 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | pprof-format | 2.2.2 | 500.53 kB | 500.53 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | node-gyp-build | 4.8.4 | 13.86 kB | 13.86 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
IlyasShabi
force-pushed
the
ishabi/restore-initial-limit
branch
from
e143f44 to
dc629db
Compare
IlyasShabi
commented
Jul 8, 2026
| if (isolate) { | ||
| isolate->AddNearHeapLimitCallback(&NearHeapLimit, nullptr); | ||
| // Restore 90% of the original heap limit when possible. | ||
| constexpr double kHeapLimitRestoreThreshold = 0.90; |
Author
There was a problem hiding this comment.
When the current size is 90% of the original one, we consider that v8 recovered and restore the original one.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Register V8’s
AutomaticallyRestoreInitialHeapLimitwhen installing the near-heap-limit callback to 95% of original size.When live old-generation heap usage drops below threshold * original_heap_limit, restore the max heap limit back to the original heap limit.
Motivation:
MonitorOutOfMemoryextends V8’s heap limit so the profiler has enough space to collect and export heap profiler. Currently if the application frees memory and recovers, that extended heap limit can remain in place which makes the headroom effectively permanent and can allow later memory growth beyond the original budget.