Skip to content

Fix: 5503, applying fixes for mobile/tablet screens - #6091

Open
abelc-escire wants to merge 2 commits into
DSpace:mainfrom
abelc-escire:fix/issue-5503
Open

Fix: 5503, applying fixes for mobile/tablet screens#6091
abelc-escire wants to merge 2 commits into
DSpace:mainfrom
abelc-escire:fix/issue-5503

Conversation

@abelc-escire

Copy link
Copy Markdown

References issue

Issue #5503

Description

Applying fixes for mobile/table screens to fit properly on those screen sizes.

Instructions for Reviewers

To test those scenarios please move to mobile/tablet screens and then follow the following instructions.

List of changes in this PR:

  • Search input on Header, now on mobile the Search input is move to the botton to avoid overlaping with the icon on the header.
  • Remove blank space on Search Items Screen, when you move through the Filter and Serch result the blank space between the filter and the footer has been removed to just keep the height needed to display it properly.
  • Footer icon and links, now on mobile/tables screens the links on the footer are displayed inline without break it and then move to the next line to fit properly on the screen size.

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR follows all coding best practices based on the Code Conventions Guide
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant