๐งฉ KRDS ์ปดํฌ๋ํธ ๋ผ์ด๋ธ๋ฌ๋ฆฌ (๋ฐ๋๋ผ HTML/CSS ๊ตฌํ์ฒด)#52
Open
seonghobae wants to merge 1 commit into
Open
๐งฉ KRDS ์ปดํฌ๋ํธ ๋ผ์ด๋ธ๋ฌ๋ฆฌ (๋ฐ๋๋ผ HTML/CSS ๊ตฌํ์ฒด)#52seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
OpenCode Review Overview
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (4 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (4 files)"]
R1 --> V1["required checks"]
|
Figma ๋์์ธ ์์คํ (6Kx2gzcduyIyLGN3Ck2rtm)์ ์ปดํฌ๋ํธ๋ฅผ ์ค์ ์ฝ๋๋ก ๊ตฌํ. ๊ธฐ์กด ๋ธ๋๋ ํ ํฐ(:root)์ ์๋นํ๊ณ KRDS status ํ ํฐ๋ง ์ถ๊ฐ. ๋น๋/ํ๋ ์์ํฌ ์์ด GitHub Pages์์ ๋ฐ๋ก ์๋น๋๋ component gallery. - components/krds-components.css: Button/Input/Checkbox/Radio/Select/Badge/Tag/ Tabs/Accordion(native details)/Pagination/Alert/Toast โ ํ ํฐ ๋ฐ์ธ๋ฉ, focus-visible(teal 2px) - components/index.html: 10๊ฐ story ๊ฐค๋ฌ๋ฆฌ(states ํฌํจ), ํ๋ ์์ํฌ ์๋ tabs/tag JS - .gitignore: ๋ก์ปฌ codegraph ์ธ๋ฑ์ค ์ ์ธ ์๋ ์ด ๋ธ๋์น์ ํจ๊ป ์๋ styles.css ํํ์ด์ง ๊ฐ์ (dikw eyebrow ๋๋น, content-visibility)์ #53ยท#54๋ก main์ ๋ ๋ฆฝ ๋จธ์ง๋์ด ์ค๋ณต ์ ๊ฑฐํจ. ์ด PR์ components/ ์ปดํฌ๋ํธ ๋ผ์ด๋ธ๋ฌ๋ฆฌ๋ง ๋ด์. ํ์ฌ main ์๋ก rebaseํ์ฌ ์ถฉ๋ ํด์. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0169KuM8Ygfmeswa4EtaL7mC
a98e988 to
b6eb389
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
๋ฌด์์
Figma ๋์์ธ ์์คํ (
6Kx2gzcduyIyLGN3Ck2rtm)์ ์ปดํฌ๋ํธ๋ฅผ ์ค์ ์ฝ๋ ๊ตฌํ์ฒด๋ก ์ถ๊ฐํฉ๋๋ค. ์ง๊ธ๊น์ง ์ปดํฌ๋ํธ๋ Figma์๋ง ์์๊ณ ๋์ ์ฝ๋๊ฐ ์์ด component-level parity๋ฅผ ์ค์ธกํ ์ ์์๋๋ฐ, ์ด PR๋ก ์ค์ ๊ตฌํ์ด ์๊น๋๋ค.์ด๋ป๊ฒ (์ค์ฝํ ๊ฒฐ์ )
๋ฐ๋๋ผ ์ ์ ์ฌ์ดํธ๋ผ Storybook + JS ํ๋ ์์ํฌ๋ ๊ณผ์ค๊ณ โ ๋น๋/ํ๋ ์์ํฌ ์๋ ๋ฐ๋๋ผ HTML/CSS ๊ฐค๋ฌ๋ฆฌ๋ก ๊ตฌํ. ๊ธฐ์กด
styles.css์ ๋ธ๋๋ ํ ํฐ(:root)์ ๊ทธ๋๋ก ์๋นํ๊ณ , KRDS status ์์(info/success/warning/danger)๋ง ์ถ๊ฐํฉ๋๋ค.ํ์ผ
components/krds-components.cssโ Button, Text Input, Checkbox/Radio, Select, Badge, Tag, Tabs, Accordion(native<details>), Pagination, Alert, Toast. ์ ๋ถ ํ ํฐ ๋ฐ์ธ๋ฉ,focus-visible๋ ์ฌ์ดํธ ์ปจ๋ฒค์ (teal 2px offset 2px) ์ค์.components/index.htmlโ 10๊ฐ story ๊ฐค๋ฌ๋ฆฌ(states ํฌํจ). Tabs/Tag ์ต์ ๋์ JS(ํ๋ ์์ํฌ ์์)..gitignoreโ ๋ก์ปฌ codegraph ์ธ๋ฑ์ค ์ ์ธ.๊ฒ์ฆ (Puppeteer @1200w, ์ค์ธก)
#16263d.button์ปจ๋ฒค์ + Figma ์คํ ์ผ์น--line#eaf5eb/ text#2e7d32#16263d๋๋๋ฆฌ๊ธฐ
์
components/๋๋ ํฐ๋ฆฌ๋ง ์ถ๊ฐ โ ๊ธฐ์กด ํ์ด์ง/์คํ์ผ ๋ณ๊ฒฝ 0. ์์ ํ๊ฒ revert ๊ฐ๋ฅ.๋ฏธ๋ฆฌ๋ณด๊ธฐ:
/components/(GitHub Pages ๋ฐฐํฌ ์ ๋ฐ๋ก ์ ๊ทผ)๐ค Generated with Claude Code
https://claude.ai/code/session_0169KuM8Ygfmeswa4EtaL7mC