docs: correct stale Windows signal references after #124 - #125
Merged
Conversation
PR #124 shipped Windows signal delivery as ConPTY-input ETX (SIGINT) + taskkill /F /T descendant-tree kill (SIGTERM/SIGKILL), superseding the planned GenerateConsoleCtrlEvent approach (which cannot reach a child on its own pseudoconsole). Three spots still described the old plan: - .github/workflows/ci.yml: test-job comment - tracker.md: cycle W2 entry (now marked shipped, with remaining open items: named-pipe DACL, real Ctrl-Break) - docs/design/windows-strategy.md: TL;DR intro (now points at the as-implemented signal table in section 2) Co-authored-by: c1-squire-dev[bot] <c1-squire-dev[bot]@users.noreply.github.com>
c1-squire-dev
Bot
force-pushed
the
paul.querna/docs-windows-signal-refs
branch
from
July 29, 2026 18:19
4e295a4 to
559c8b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #124 shipped Windows signal delivery as ConPTY-input ETX (SIGINT) +
taskkill /F /Tdescendant-tree kill (SIGTERM/SIGKILL), superseding theplanned
GenerateConsoleCtrlEventapproach (which cannot reach a child on itsown pseudoconsole). Three spots still describe the old plan:
.github/workflows/ci.yml— thetestjob comment.tracker.md— the cycle W2 entry (now marked shipped, with the remainingopen items called out: named-pipe DACL, real Ctrl-Break).
docs/design/windows-strategy.md— the TL;DR intro (now points at theas-implemented signal table in §2, which Windows/ConPTY parity: rendering, signals, tree-kill, and the run|consumer hang #124 already updated).
Docs-only; no code changes.
Testing
cargo check --workspacepasses (Linux aarch64).🤖 Generated with Claude Code + Squire