Stop double Slack announcement of schema-sync PRs; ping Mona + Nicki (DS-1133) - #38
Draft
monazhu wants to merge 2 commits into
Draft
Stop double Slack announcement of schema-sync PRs; ping Mona + Nicki (DS-1133)#38monazhu wants to merge 2 commits into
monazhu wants to merge 2 commits into
Conversation
slack-pr-notify.yml assumed bot-opened PRs cannot trigger pull_request workflows (anti-recursion). In practice GitHub creates those runs parked at action_required, and they execute when a human hits 'Approve and run workflows' — so every automation PR was announced twice (observed on PR #37, 2026-08-31). Guard the notify job on PR author != github-actions[bot]; schema-sync's inline step remains the single announcement. Also (DS-1133, parity with cvr-analyst and c3d-cognitive3dpy): the inline message now names the actual unblock action (Checks -> Approve and run workflows), fires on refresh too (a force-push re-parks the checks), and a failure() step reports SLICER_READ_TOKEN-style sync failures that cortex's dispatch leg cannot see.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes to the Slack notifications:
Double announcement (observed on #37 today)
slack-pr-notify.ymlassumed bot-opened PRs can't triggerpull_requestworkflows (anti-recursion). Reality: GitHub creates those runs parked at action_required, and they execute the moment someone hits Approve and run workflows — announcing the PR a second time. Fixed with an author guard (user.login != 'github-actions[bot]'); schema-sync's inline step remains the single announcement. Comments corrected in both files.Pings + message content (DS-1133 parity with cvr-analyst / c3d-cognitive3dpy)
if: failure()step reports sync failures (e.g. expiredSLICER_READ_TOKEN) — invisible from cortex's dispatch leg, which only sees 204/queued.🤖 Generated with Claude Code