Add functional tests for inherited Symfony assertions (8.1)#46
Merged
Merged
Conversation
Covers the assertion/getter methods added in Codeception/module-symfony#240: - BrowserCest: assertBrowserHistoryIsOnFirstPage, assertBrowserHistoryIsNotOnFirstPage, assertBrowserHistoryIsOnLastPage - DomCrawlerCest: assertSelectorCount, assertAnySelectorTextContains, assertAnySelectorTextSame, assertAnySelectorTextNotContains - MailerCest: getMailerEvents, getMailerMessages, getMailerMessage - MimeCest: assertEmailAddressNotContains, assertEmailSubjectContains, assertEmailSubjectNotContains Refreshes composer.lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Functional tests for the inherited Symfony assertions added in Codeception/module-symfony#240.
Added tests
assertBrowserHistoryIsOnFirstPage,assertBrowserHistoryIsNotOnFirstPage,assertBrowserHistoryIsOnLastPageassertSelectorCount,assertAnySelectorTextContains,assertAnySelectorTextSame,assertAnySelectorTextNotContainsgetMailerEvents,getMailerMessages,getMailerMessageassertEmailAddressNotContains,assertEmailSubjectContains,assertEmailSubjectNotContainsAll new methods are placed in alphabetical order, reuse the existing fixtures (
/test_page,/send-email,registerUser()), and pass locally against module-symfony#240.composer.lockrefreshed.Notes
assertBrowserHistoryIsNotOnLastPageis intentionally not covered here: a "not on last page" state requires a rawclient->back()(which keeps forward history), but the Codeception actor API only exposesmoveBack(), which re-dispatches and truncates forward history — making the state unreachable via functional steps. It is covered by the unit test in module-symfony#240.main.yml) currently pins Symfony8.0, not8.1, so these tests won't be exercised by module-symfony CI until that matrix is bumped to8.1. Companion PRs cover 5.4 / 6.4 / 7.4.