London | 26-JUL-SDC | Ping Wang | Sprint 4 | Implement-shell-tools - #634
London | 26-JUL-SDC | Ping Wang | Sprint 4 | Implement-shell-tools#634pathywang wants to merge 9 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
pathywang
changed the title
pathywang
added
the
Needs Review
pathywang
added
Needs Review
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start, but some things to fix.
also, Is the choice you have used for processing arguments the most effective? Is there a library you could use to help the implementation?
| output = [] | ||
|
|
||
| if count_lines: | ||
| output.append(str(lines)) |
There was a problem hiding this comment.
If you run this with multiple files, how does the output look? What change could make it neater?
There was a problem hiding this comment.
the colums do not line up very well because the numbers have different length so i formatted the string with fixted length 8.
|
|
||
| if len(files) > 1: | ||
| output = [] | ||
|
|
There was a problem hiding this comment.
What do you think about the output code here? Can you spot any duplication across the file?
There was a problem hiding this comment.
yes there are nearly two identical codes so i define print_out function then call twice later on, refactor code
LonMcGregor
added
Reviewed
|
i manually use sys.agrv instead of import argparse from librares, i noticed it then i would use import argparse later on which should be better. thanks |
pathywang
added
Needs Review
2 participants
Changelist
As usual, i did prep then made branch from main, create new file and did coursework with python language which is mirrored the same task with JavaScript language, still hard with AI explanatio and require lots of memorization and review
Task ID: CYF-1152