Birmingham | 26-JUL-SDC | Merve Reis | Sprint 3 | Sheel Tools - #614
Open
mervereis wants to merge 1 commit into
Open
Birmingham | 26-JUL-SDC | Merve Reis | Sprint 3 | Sheel Tools#614mervereis wants to merge 1 commit into
mervereis wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
mervereis
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Aug 4, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Good start but there is still a lot to do here.
Is your way of handling options/arguments the best? Is there a better way of doing this?
|
|
||
| if (numberNonBlank) { | ||
| if (line.trim() === "") { | ||
| process.stdout.write(output); |
Contributor
There was a problem hiding this comment.
When I am looking at the output of blank lines I get some odd formatting, do you see this in your testing?
| } | ||
| } | ||
|
|
||
| if (!onePerLine) { |
Contributor
There was a problem hiding this comment.
What is this last empty log doing?
|
|
||
| if (filesCounted > 1) { | ||
| let result = ""; | ||
| if (countLines) { |
Contributor
There was a problem hiding this comment.
This printing code looks to be repeated, do you think you could reduce the duplication somehow?
| } | ||
| result += "total"; | ||
|
|
||
| console.log(result); |
Contributor
There was a problem hiding this comment.
When you have multiple files, is the output formatting as good as it could be? How could it be made neater?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… features
Learners, PR Template
Self checklist
Completed all the tasks.
Task ID: CYF-1150