WestMidlands | 26-SDC-Mar | Chioma Okeke | Sprint 5 | prep exercises - #545
Open
JanefrancessC wants to merge 1 commit into
Open
WestMidlands | 26-SDC-Mar | Chioma Okeke | Sprint 5 | prep exercises#545JanefrancessC wants to merge 1 commit into
JanefrancessC wants to merge 1 commit into
Conversation
JanefrancessC
added
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Aug 3, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Good work on these, I have a couple of minor comments
| @@ -0,0 +1,21 @@ | |||
| from dataclasses import dataclass | |||
| from typing import List | |||
| # from datetime import date | |||
Contributor
There was a problem hiding this comment.
Remember if you don't need code , it shouldn't be committed. Is there a reason you want to keep this commented?
| preferred_os = OperatingSystem(os_input) | ||
| except ValueError: | ||
| print("Invalid operating system.") | ||
| exit() |
Contributor
There was a problem hiding this comment.
Is there a more graceful way of handling the input validation?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed the prep exercises in Sprint 5