London | 26-ITP-May | Vito Moratti | Sprint 3 | practice tdd#1526
Open
vmoratti wants to merge 9 commits into
Open
London | 26-ITP-May | Vito Moratti | Sprint 3 | practice tdd#1526vmoratti wants to merge 9 commits into
vmoratti wants to merge 9 commits into
Conversation
vmoratti
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jul 22, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start, I have a few follow up comments
| let count = 0; | ||
| for (let char of stringOfCharacters) { | ||
| if (char === findCharacter) { | ||
| count ++; |
There was a problem hiding this comment.
Purely a matter a style, I recommend putting the increment operator immediately after the variable, without a space.
| @@ -1,5 +1,32 @@ | |||
| function getOrdinalNumber(num) { | |||
| return "1st"; | |||
| if (num % 100 === 11) { | |||
There was a problem hiding this comment.
As these first 3 branches are all returning the same thing, is there a way they could be simplified?
Author
There was a problem hiding this comment.
I have now changed it and combined those branches in one.
|
|
||
| module.exports = repeatStr; | ||
| //console.log(repeatStr("hello", -1)); | ||
| //console.log(repeatStr("hello", 0)); |
There was a problem hiding this comment.
Remember to remove commented out code if it is not needed
| var i; | ||
| if (num < 0) { | ||
| throw new Error("negative numbers are not valid"); | ||
| } else if (num === 0) { |
There was a problem hiding this comment.
What does this special num===0 case do?
Author
There was a problem hiding this comment.
Thanks. I have now removed it and code is works still.
LonMcGregor
added
Reviewed
Updated the getOrdinalNumber function to correctly handle numbers ending in 11, 12, and 13 as 'th'. Added additional test cases for validation.
Removed unnecessary checks for zero and commented-out test cases.
vmoratti
added
the
Needs Review
|
Great! This task is complete now |
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I had to rewrite all the code and tests.