-
-
Notifications
You must be signed in to change notification settings - Fork 395
Birmingham | 26-ITP-May | Ogbemi Mene | sprint 3 | 2-practice TDD coursework exercises #1491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
meneogbemi42-bit
wants to merge
9
commits into
CodeYourFuture:main
Choose a base branch
from
meneogbemi42-bit:Sprint-3/-Practice-TDD-Coursework-Exercises
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0dc502d
count function
9733fa3
count.test answer
7991a9b
getting ordinal num
0e7fe70
test.js for ordinal num
0463407
the new code without API( application programm interface).
meneogbemi42-bit 4e621d4
Update test cases for getOrdinalNumber function
meneogbemi42-bit 1a46ec8
commit for repeat
8657ab8
commit test
0347b66
Merge branch 'Sprint-3/-Practice-TDD-Coursework-Exercises' of https:/…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,13 @@ | ||
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| let count = 0; | ||
|
|
||
| for (let i = 0; i < stringOfCharacters.length; i++) { | ||
| if (stringOfCharacters[i] === findCharacter) { | ||
| count++; | ||
| } | ||
| } | ||
|
|
||
| return count; | ||
| } | ||
|
|
||
| module.exports = countChar; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,43 @@ | ||
| function getOrdinalNumber(num) { | ||
| return "1st"; | ||
| //function getOrdinalNumber(num) { | ||
| //return "1st"; | ||
| //} | ||
|
|
||
| //module.exports = getOrdinalNumber; | ||
| // this is a code i came up with to get the ordinal number of a given number. | ||
| // I will now write tests to check if it works correctly. | ||
|
|
||
| //function getOrdinalNumber(n) { | ||
| //const pr = new Intl.PluralRules("en-US", { type: "ordinal" }); | ||
| //const suffixes = { one: "st", two: "nd", few: "rd", other: "th" }; | ||
| //const rule = pr.select(n); | ||
| //return `${n}${suffixes[rule]}`; | ||
| //} | ||
|
|
||
| // code without any API | ||
|
|
||
| function getOrdinalNumber(n) { | ||
| // Pure arithmetic to get absolute value without Math.abs() | ||
| let positiveN; | ||
| if (n < 0) { | ||
| positiveN = -n; | ||
| } else { | ||
| positiveN = n; | ||
| } | ||
|
|
||
| const lastTwoDigits = positiveN % 100; | ||
| const lastDigit = positiveN % 10; | ||
|
|
||
| // Teens exception: 11th, 12th, 13th | ||
| if (lastTwoDigits >= 11 && lastTwoDigits <= 13) { | ||
| return `${n}th`; | ||
| } | ||
|
|
||
| // Standard endings | ||
| if (lastDigit === 1) return `${n}st`; | ||
| if (lastDigit === 2) return `${n}nd`; | ||
| if (lastDigit === 3) return `${n}rd`; | ||
|
|
||
| return `${n}th`; | ||
| } | ||
|
|
||
| module.exports = getOrdinalNumber; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,15 @@ | ||
| function repeatStr() { | ||
| // Your implementation of this function must *not* call String.prototype.repeat (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat). | ||
| // The goal is to re-implement that function, not to use it. | ||
| return "hellohellohello"; | ||
| function repeatStr(str, count) { | ||
| // Native String.prototype.repeat throws a RangeError for negative counts | ||
| if (count < 0) { | ||
| throw new RangeError("Invalid count value"); | ||
| } | ||
|
|
||
| let result = ""; | ||
| for (let i = 0; i < count; i++) { | ||
| result += str; | ||
| } | ||
|
|
||
| return result; | ||
| } | ||
|
|
||
| module.exports = repeatStr; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation is off.
Could also just use
Math.abs()