Glasgow | 26-ITP-May | Niangh Ciang | Sprint 2 | Exercises#1246
Open
Niangh-Ciang wants to merge 14 commits into
Open
Glasgow | 26-ITP-May | Niangh Ciang | Sprint 2 | Exercises#1246Niangh-Ciang wants to merge 14 commits into
Niangh-Ciang wants to merge 14 commits into
Conversation
Niangh-Ciang
added
📅 Sprint 2
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jul 20, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on doing the stretch tasks. I have one question about one of the tasks, can you answer it?
| return queryParams; | ||
| } | ||
| const keyValuePairs = queryString.split("&"); | ||
| const replacePlusWithSpace = (str) => str.replace(/\+/g, " "); |
There was a problem hiding this comment.
What are you doing with this replacement?
Author
There was a problem hiding this comment.
I added this replacement to convert all + characters into spaces. One of the tests checks this behaviour, and since decodeURIComponent doesn’t handle +, this step is required to pass the test.
There was a problem hiding this comment.
Good explanation, the task is complete now
LonMcGregor
added
Reviewed
Niangh-Ciang
added
Needs Review
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Completed Sprint 2 exercises.