Fix seamless Media Playlist Source playback with dual media sources - #60
Open
Vencite wants to merge 5 commits into
Open
Fix seamless Media Playlist Source playback with dual media sources#60Vencite wants to merge 5 commits into
Vencite wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59
Summary
Media Playlist Source could become invisible or render a blank/transparent frame when changing to another playlist file. This PR implements seamless dual-source playback.
Root cause
The single internal
ffmpeg_sourcecleared its output toNULLbeforemedia_ended, so the parent could render a transparent/blank frame during a file change.Solution
Compatibility
The change preserves the existing public source ID, persisted settings keys, playlist controls, and scene collection compatibility.
Tests
6d4124bverified by GitHub Actions on Ubuntu, Windows and macOS.26abc4e; the implementation was then carried into this clean PR branch. The exact final commit6d4124bpassed the full GitHub Actions CI/build verification.Manual regression coverage
The manual regression checklist is included in
tests/manual-regression.mdand covers: