SSF-233 Pantry Confirm Delivery Email#194
Open
Juwang110 wants to merge 2 commits into
Open
Conversation
dburkhart07
requested changes
Jun 23, 2026
| .getMany(); | ||
|
|
||
| if (orders.length === 0) { | ||
| this.logger.warn( |
There was a problem hiding this comment.
this isnt really something being wrong, can we just make it a logger.log instead?
| match.status === OrderStatus.SHIPPED | ||
| ) { | ||
| setSelectedActionOrder(match); | ||
| navigate(ROUTES.PANTRY_ORDER_MANAGEMENT, { replace: true }); |
There was a problem hiding this comment.
for most of our modals, i think we navigate only on closing, as opposed to opening them and then renavigating. can we follow that logic here?
| if (!existingShippedOrder) | ||
| throw new Error('Missing existingShippedOrder test object'); | ||
|
|
||
| const before = (await eligibleOrders()).length; |
There was a problem hiding this comment.
what is the point of this before variable? can we not just check how many unconfirmed orders we have for this pantry after adding this secondOrder, and then just check the emails service is called for this one?
| }); | ||
| }); | ||
|
|
||
| describe('sendConfirmDeliveryReminders', () => { |
There was a problem hiding this comment.
can we add a test somewhere that makes sure each of the orders we use to send an email for is SHIPPED?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/browse/SSF-233
📝 Description
I added a new Pantry Confirm Delivery Automated Email that reminds pantries to complete required actions on shipped orders. This is accompanied with a weekly cron job reminder.
✔️ Verification
Verified cron job and email sending works by having it send every 10 seconds.
🏕️ (Optional) Future Work / Notes
N/A