Skip to content

fix: Drop the anonymous namespace from the benchmark URI #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chfast wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Drop the anonymous namespace from the benchmark URI #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions core/src/uri.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,22 @@
#include <iostream>
#include <string>

#include "codspeed.h"

namespace codspeed {

// The anonymous namespace is not a part of any identifier the benchmark can be referred to by,
// and its spelling differs between the compilers, so it is dropped from the namespace path.
// Example: {anonymous}::outer:: (GCC) or (anonymous namespace)::outer:: (clang)
// Returns: outer::
std::string strip_anonymous_namespace(std::string ns) {
for (const std::string anon : {"{anonymous}::", "(anonymous namespace)::"}) {
for (auto pos = ns.find(anon); pos != std::string::npos; pos = ns.find(anon)) {
ns.erase(pos, anon.size());
}
}
return ns;
}

// Example: auto outer::test12::(anonymous class)::operator()() const
// Returns: outer::test12::
std::string extract_namespace_clang(const std::string &pretty_func) {
Expand Down Expand Up @@ -36,16 +48,10 @@ std::string extract_namespace_gcc(const std::string &pretty_func) {
// Returns: An empty string if the namespace could not be extracted,
// otherwise the namespace with a trailing "::"
std::string extract_lambda_namespace(const std::string &pretty_func) {
if (pretty_func.find("(anonymous namespace)") != std::string::npos) {
std::cerr << "[ERROR] Anonymous namespace not supported in " << pretty_func
<< std::endl;
return {};
}

#ifdef __clang__
return extract_namespace_clang(pretty_func);
return strip_anonymous_namespace(extract_namespace_clang(pretty_func));
#elif __GNUC__
return extract_namespace_gcc(pretty_func);
return strip_anonymous_namespace(extract_namespace_gcc(pretty_func));
#elif _MSC_VER
// MSVC doesn't support __PRETTY_FUNCTION__ in the same way
// Return empty string as fallback for Windows
Expand Down