test(backend): cover the live reader-values CSV path#43
Conversation
Adds direct tests for generate_csv_response_scalar/series and parse_dimension_filters in reader_values.py, the live path the CSV download routes call. Also covers file_iterator's chunked reading and the Settings default-secret guard, both previously untested.
✅ Deploy Preview for climate-ref canceled.
|
|
Warning Review limit reached
Next review available in: 28 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adds direct tests for the code paths the audit found untested: the reader-backed CSV exports, chunked file streaming, and the config secret guard.
test_reader_values.pypins the CSV column contract using realScalarValueCollection/SeriesValueCollectioninstances, covering header layout with and without outlier detection, theX-REF-*headers, NaN sanitization, and the series index fallbacks.test_file_handling.pycoversfile_iteratorchunking.test_config.pycovers the default-secret guard (raises outside local, warns in local) andparse_cors.These pin the CSV contract that previously was only asserted against a dead pre-Reader copy of the generators (removed in #42). A future climate-ref bump that changes the collection shapes will fail here first.