ci: replace pre-releases with PR build artifacts - #86
Open
Cliffback wants to merge 1 commit into
Open
Conversation
Drop the durable "release candidate" pre-release workflows (pre-release.yml, cleanup-pre-releases.yml). They created a semver git tag that interfered with release-please and cluttered the releases page. Instead, produce 90-day build artifacts in experimental-build: automatically for release-please PRs, and on demand via the test-build label for other PRs. Bump test-build retention to 90 days.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The label-triggered
pre-release.ymlcreated a real semver git tag (vX.Y.Z-rc.N) plus a GitHub pre-release. Because release-please computes the next version from the highest semver tag, that RC tag made it treat the RC as the current release and produced the next PR as1.10.0-rc.1instead of a stable1.9.0— the "release candidate in the title" bug. It also cluttered the releases page.Change
Drop the durable "release candidate" mechanism and use build artifacts instead:
pre-release.ymlandcleanup-pre-releases.yml(no more RC git tags → release-please is untouched, no release-page clutter).opened/synchronize) and on demand via thetest-buildlabel for any other PR. A download link is posted in a PR comment (replaced in place); older artifacts self-expire after 90 days. Label removal is now guarded so it only runs when label-triggered.Result
test-buildlabel.test-build.yml).