Skip to content

Fix Tinybird benchmark runner auth#952

Open
fallintoplace wants to merge 1 commit into
ClickHouse:mainfrom
fallintoplace:fix-tinybird-runner-auth
Open

Fix Tinybird benchmark runner auth#952
fallintoplace wants to merge 1 commit into
ClickHouse:mainfrom
fallintoplace:fix-tinybird-runner-auth

Conversation

@fallintoplace

Copy link
Copy Markdown

What changed

  • Replaced the placeholder auth header with a required TINYBIRD_TOKEN environment variable.
  • Switched Tinybird requests to Authorization: Bearer ... and made curl fail on HTTP errors.
  • Made the runner fail fast on shell errors and invalid/non-numeric statistics.elapsed values.
  • Documented the required token in the Tinybird README.

Why

AUTH_HEADER=<TOKEN> is parsed by the shell as redirection syntax, so tinybird/run.sh fails before it can run any benchmark query.

Validation

  • bash -n tinybird/run.sh
  • env -u TINYBIRD_TOKEN ./tinybird/run.sh
  • mocked successful Tinybird responses and checked the output is a 43-entry JSON array with three numeric timings per query
  • mocked a non-numeric statistics.elapsed response and confirmed the runner exits non-zero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant