Skip to content

docs: add createCartoTheme: look and feel & ui - #78

Open
AdriSolid wants to merge 1 commit into
masterfrom
adri/add-createCartoTheme-docs
Open

AdriSolid wants to merge 1 commit into
masterfrom
adri/add-createCartoTheme-docs

Conversation

@AdriSolid

Copy link
Copy Markdown
Contributor

CARTO for React: docs for createCartoTheme.

@github-actions

github-actions Bot commented Apr 8, 2021

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 0116e08):

https://cartodb-fb-documentation--pr78-adri-add-createcarto-u8bfy7ez.web.app

(expires Thu, 15 Apr 2021 14:20:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

...
import { cartoThemeOptions, createCartoTheme } from '@carto/react-ui';
...
cartoThemeOptions.palette.primary.main = "#800000";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdriSolid don't we need to pass here the object to the new method as param?

A set of UI elements to build CARTO for React applications.

The package includes 2 main elements: a set of values to use a Material UI theme with CARTO brand (`cartoThemeOptions`) + a group of widgets:
The package includes 2 main elements: a set of values to use a Material UI theme with CARTO brand (`createCartoTheme` and `cartoThemeOptions`) + a group of widgets:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As createCartoTheme is strictly a method, how about...

The package includes some utilities to create a Material UI theme with CARTO brand (createCartoTheme and cartoThemeOptions) + a group of widgets

@Jesus89
Jesus89 force-pushed the master branch 2 times, most recently from db0116a to 3121397 Compare April 30, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants