Firefly-2078: Refactor ImagePlotCntrl.js remove circular dependancies - #1990
Open
robyww wants to merge 1 commit into
Open
Firefly-2078: Refactor ImagePlotCntrl.js remove circular dependancies#1990robyww wants to merge 1 commit into
robyww wants to merge 1 commit into
Conversation
robyww
force-pushed
the
FIREFLY-2078-circular
branch
3 times, most recently
from
August 5, 2026 19:29
bad1d21 to
718c2ef
Compare
robyww
force-pushed
the
FIREFLY-2078-circular
branch
from
August 5, 2026 20:24
718c2ef to
29d0a1b
Compare
robyww
marked this pull request as ready for review
August 5, 2026 22:10
robyww
force-pushed
the
FIREFLY-2078-circular
branch
6 times, most recently
from
August 5, 2026 23:21
d2c28bc to
9ae4852
Compare
- break up ImagePlotCntlr.js and MultViewCntlr.js - VisConst.js, ImagePlotDispatch.js, visRoot.js - in addition put other constants in VisConst.js
robyww
force-pushed
the
FIREFLY-2078-circular
branch
from
August 6, 2026 21:34
9ae4852 to
df8ea04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefly-2078: Refactor ImagePlotCntrl.js remove circular dependancies
getPV()andprimePlotById()for easier access out of the the reducer context. You do not needvisRoot()Testing: