Skip to content

Fix Thold integration dependency installation - #777

Merged
TheWitness merged 4 commits into
Cacti:developfrom
somethingwithproof:ci/fix-thold-integration-dependencies
Aug 17, 2026
Merged

Fix Thold integration dependency installation#777
TheWitness merged 4 commits into
Cacti:developfrom
somethingwithproof:ci/fix-thold-integration-dependencies

Conversation

@somethingwithproof

Copy link
Copy Markdown
Member

Summary

  • remove the unavailable Ubuntu-versioned Apache PHP package from the integration matrix

The matrix PHP executable is supplied by setup-php; the integration suite runs through the CLI and does not require an Apache module.

Validation

  • git diff --check
  • workflow YAML parsed successfully

Kept separate from #773 so the security hardening remains focused.

Copilot AI review requested due to automatic review settings July 14, 2026 05:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions integration-test workflow to avoid installing an Ubuntu-versioned Apache PHP module that is not reliably available across the PHP matrix, relying instead on setup-php for the CLI PHP runtime.

Changes:

  • Removed libapache2-mod-php${{ matrix.php }} from the system dependency installation step in the integration workflow.

Comment thread .github/workflows/plugin-ci-workflow.yml
@somethingwithproof

Copy link
Copy Markdown
Member Author

Re-verified: branch is up to date with develop (no rebase needed), all 4 Integration Test checks currently pass. One Copilot thread on plugin-ci-workflow.yml:90 (about /usr/bin/php not existing after removing the apt package) is marked outdated — the concern looks already addressed by this PR's own $PHP_BINARY capture/usage further down the diff, so leaving it as-is. No changes pushed.

@TheWitness
TheWitness merged commit 22633ed into Cacti:develop Aug 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants