Skip to content

hardening: prepared statements, PHP 7.4 idioms, and security fixes #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
somethingwithproof wants to merge 2 commits into
base: develop
Choose a base branch
from
+53 −0
Open

hardening: prepared statements, PHP 7.4 idioms, and security fixes #51

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b014d26
chore: use filtered audit user id binding
somethingwithproof Jul 29, 2026
b95d7c6
Merge remote-tracking branch 'origin/develop' into pr-51
somethingwithproof Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions tests/e2e/test_security_wiring.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
<?php
/*
+-------------------------------------------------------------------------+
| Copyright (C) 2004-2026 The Cacti Group |
| |
| End-to-end wiring checks for audit security fixes. |
| |
| Run: php tests/e2e/test_security_wiring.php |
+-------------------------------------------------------------------------+
*/

$pass = 0;
$fail = 0;

function assert_true($label, $value) {
global $pass, $fail;

if ($value) {
echo "PASS $label\n";
$pass++;
} else {
echo "FAIL $label\n";
$fail++;
}
}

$source = file_get_contents(__DIR__ . '/../../audit.php');

assert_true(
'user_id filter uses integer normalization before prepared SQL binding',
substr_count($source, "get_filter_request_var('user_id')") === 2
);

assert_true(
'event_page filter documents string binding',
substr_count($source, 'event_page is a sanitized page basename') === 2
);

assert_true(
'detail popup escapes field names and values',
strpos($source, "html_escape(\$field)") !== false &&
strpos($source, "audit_render_value(\$content)") !== false
);

assert_true(
'record data json is escaped before rendering',
strpos($source, "html_escape(json_encode(\$record, JSON_PRETTY_PRINT | JSON_INVALID_UTF8_SUBSTITUTE))") !== false
);

echo "\n";
echo "Results: $pass passed, $fail failed\n";

exit($fail > 0 ? 1 : 0);
Loading