fix(harvester): handle legacy CDS recid checks before create - #931
Open
TahaKhan998 wants to merge 1 commit into
Open
fix(harvester): handle legacy CDS recid checks before create#931TahaKhan998 wants to merge 1 commit into
TahaKhan998 wants to merge 1 commit into
Conversation
TahaKhan998
force-pushed
the
fix/issue-907-harvester-legacy-duplicates
branch
16 times, most recently
from
August 19, 2026 11:23
f21a51c to
7b3fef1
Compare
kpsherva
reviewed
Aug 19, 2026
kpsherva
reviewed
Aug 19, 2026
kpsherva
reviewed
Aug 19, 2026
kpsherva
reviewed
Aug 19, 2026
kpsherva
reviewed
Aug 19, 2026
kpsherva
reviewed
Aug 19, 2026
kpsherva
reviewed
Aug 19, 2026
kpsherva
reviewed
Aug 19, 2026
kpsherva
reviewed
Aug 19, 2026
TahaKhan998
force-pushed
the
fix/issue-907-harvester-legacy-duplicates
branch
4 times, most recently
from
August 21, 2026 08:30
00012a8 to
c657a94
Compare
kpsherva
reviewed
Aug 21, 2026
kpsherva
reviewed
Aug 21, 2026
kpsherva
reviewed
Aug 21, 2026
TahaKhan998
force-pushed
the
fix/issue-907-harvester-legacy-duplicates
branch
from
August 21, 2026 14:24
c657a94 to
7a31dab
Compare
kpsherva
reviewed
Aug 21, 2026
TahaKhan998
force-pushed
the
fix/issue-907-harvester-legacy-duplicates
branch
from
August 21, 2026 14:42
7a31dab to
6eea851
Compare
kpsherva
reviewed
Aug 21, 2026
TahaKhan998
force-pushed
the
fix/issue-907-harvester-legacy-duplicates
branch
3 times, most recently
from
August 21, 2026 15:47
490ad97 to
a3d82f6
Compare
kpsherva
reviewed
Aug 21, 2026
TahaKhan998
force-pushed
the
fix/issue-907-harvester-legacy-duplicates
branch
from
August 21, 2026 15:52
a3d82f6 to
58f8a06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #907
This PR changes how the INSPIRE harvester handles records with a legacy CDS recid and avoids duplicates between old CDS and CDS-RDM. If the incoming record has an integer legacy recid, we first check pidstore and update when it is found. If it is not found, we check old CDS directly. We raise an error when it redirects to repository.cern or returns 404. We skip with a warning when the record is still only in legacy. If there is no legacy recid in the incoming record, the existing matching flow stays the same. If INSPIRE sends more than one CDS recid (merged records keep both), we check each in pidstore and on old CDS. Two different pidstore hits are treated as multiple records match.