ci: prevent incomplete Linux release archives - #53
Open
lindixu6-hash wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The published
v1.1.2Linux asset reproduces Issue #50:locales/andresources/are empty in the outer archiveLICENSE.zipresources/app, so the application exits without its packaged sourceThe asset has more than 2,500 downloads, so this is a release-process failure rather than an isolated local setup issue.
Change
resources/app, the document worker, locale payloads, and unexpected nested ZIPsThis is complementary to #52: that PR fixes the runtime Worker path, while this PR ensures the Worker and the rest of
resources/appare actually present in future release assets.Verification
npm test: 2/2 passnpm run verify:package -- out/chatd-linux-x64: pass on a real packagenpm run make -- --targets=@electron-forge/maker-zip --platform=linux --arch=x64: passunzip -tq out/make/zip/linux/x64/chatd-linux-x64-1.0.0.zip: passresources/app/package.jsonresources/app/src/index.jsresources/app/src/service/worker.js.pakfilesLICENSE.zipAfter merge, Issue #50 still requires rebuilding and replacing the v1.1.2 Linux asset or publishing a patch release; this PR prevents recurrence rather than silently changing an existing release.
Remote fork CI independently reproduced the full Linux package path:
87a7e689af5c2c7948833e4d00e58a65fe0703a0