Skip to content

Redact Express signing secrets from errors - #9429

Merged
mmcshinsky-bitgo merged 1 commit into
masterfrom
pt-000000-express-error-redaction
Aug 5, 2026
Merged

Redact Express signing secrets from errors#9429
mmcshinsky-bitgo merged 1 commit into
masterfrom
pt-000000-express-error-redaction

Conversation

@mmcshinsky-bitgo

@mmcshinsky-bitgo mmcshinsky-bitgo commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Redact request-provided signing secrets from Express error messages and attached results.
  • Redact those values from 5xx stack logging.
  • Add regression coverage for private-key and wallet-passphrase leakage.

Test plan

  • git diff --check
  • IDE linter diagnostics are clean
  • Run targeted Express tests in CI; local Yarn/Mocha execution is unavailable because the checkout lacks Yarn and a workspace Mocha binary.

PT-000000

@mmcshinsky-bitgo mmcshinsky-bitgo changed the title PT-000000: Redact Express signing secrets from errors Redact Express signing secrets from errors Aug 5, 2026
mmcshinsky-bitgo added a commit that referenced this pull request Aug 5, 2026
Remove request-provided signing secrets from Express error responses and
5xx logs while preserving non-sensitive diagnostic context.

PT-000000 #9429
@mmcshinsky-bitgo
mmcshinsky-bitgo force-pushed the pt-000000-express-error-redaction branch 2 times, most recently from 0dd8725 to 9209bc2 Compare August 5, 2026 18:42
Remove request-provided signing secrets from Express error responses and
5xx logs while preserving non-sensitive diagnostic context.

#9429
@mmcshinsky-bitgo mmcshinsky-bitgo self-assigned this Aug 5, 2026
@mmcshinsky-bitgo
mmcshinsky-bitgo marked this pull request as ready for review August 5, 2026 20:52
@mmcshinsky-bitgo
mmcshinsky-bitgo requested review from a team as code owners August 5, 2026 20:52
@mmcshinsky-bitgo
mmcshinsky-bitgo merged commit fa8f65e into master Aug 5, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants