fix(sdk-core,express): allow passwordless OFC wallet generation - #9428
Merged
zahin-mohammad merged 1 commit intoAug 6, 2026
Merged
Conversation
Contributor
zahin-mohammad
commented
Aug 5, 2026
zahin-mohammad
force-pushed
the
WCN-1859-passwordless-ofc-wallet-generation
branch
3 times, most recently
from
August 5, 2026 18:43
064af60 to
5744bc8
Compare
zahin-mohammad
force-pushed
the
WCN-1859-passwordless-ofc-wallet-generation
branch
from
August 5, 2026 18:48
5744bc8 to
5c49714
Compare
zahin-mohammad
marked this pull request as ready for review
August 5, 2026 19:03
danielpeng1
approved these changes
Aug 5, 2026
gokulhost
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow OFC trading wallets created with
userKeySigningRequired: falseto omitpassphraseandpasscodeEncryptionCode.The exported Go Account options codec now models both valid request shapes:
userKeySigningRequiredomitted,true, orfalse;userKeySigningRequired: falseand omits both password fields.Supplying only one password field is rejected. The passwordless path uploads a public-only structural user keychain and omits
encryptedWalletPassphrase; the existing password-backed encryption behavior is unchanged.Issue Number
WCN-1859
Type of change
How Has This Been Tested?
yarn --cwd modules/express mocha --no-config --require tsx --timeout 60000 test/unit/typedRoutes/generateWallet.ts— 22 passingyarn --cwd modules/sdk-core nyc -- mocha test/unit/bitgo/wallet/walletOptionsCodecs.ts test/unit/bitgo/wallet/walletsGoAccount.ts— 14 passingyarn --cwd modules/sdk-core build --forceyarn --cwd modules/express buildsocket hang upin the canonical-address suite; isolated rerun of that suite passed 60/60.Tested with the repository-pinned Node.js 24.13.0.
Checklist