feat(sdk-coin-iota): add MPCv2 signed hot recovery support - #9426
Draft
Marzooqa wants to merge 1 commit into
Draft
feat(sdk-coin-iota): add MPCv2 signed hot recovery support#9426Marzooqa wants to merge 1 commit into
Marzooqa wants to merge 1 commit into
Conversation
Detects MPCv1 vs MPCv2 keycard format in Iota.recover() and dispatches signing accordingly, mirroring the SOL implementation. MPCv2 signatures are wrapped in the existing SUI-style envelope (0x00 flag + 64-byte sig + 32-byte pubkey). TICKET: WCI-1226
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Iota.recover(), alongside the existing MPCv1 path (auto-detected, no new params)EDDSAUtils.isEddsaMpcV1SigningMaterialand dispatches signing accordingly, mirroring the SOL implementation (WCI-398)EDDSAUtils.getEddsaMpcV2RecoveryKeySharesFromReducedKey+EDDSAUtils.signRecoveryEddsaMPCv2, validatescommonKeyChainagainstbitgoKey, and wraps the resulting 64-byte signature in the existing SUI-style envelope (0x00flag byte + 64-byte sig + 32-byte pubkey)recoverConsolidations()MPCv2 support is out of scope, tracked separately in WCI-1235Test plan
{ serializedTx, scanIndex }with correctly-formed signature envelopebitgoKeyvs keycardcommonKeyChain— throwsyarn unit-test(251 passing),tsc --noEmit,eslintall cleanTICKET: WCI-1226
🤖 Generated with Claude Code