Skip to content

Bind Express wallet signing to route identity - #9419

Draft
mmcshinsky-bitgo wants to merge 1 commit into
masterfrom
pt-000000-express-wallet-binding
Draft

Bind Express wallet signing to route identity#9419
mmcshinsky-bitgo wants to merge 1 commit into
masterfrom
pt-000000-express-wallet-binding

Conversation

@mmcshinsky-bitgo

@mmcshinsky-bitgo mmcshinsky-bitgo commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Reject wallet transaction signing requests whose txPrebuild.walletId differs from the route wallet ID.
  • Apply the check to regular wallet and TSS wallet signing routes.
  • Add regression coverage proving mismatches are rejected before wallet lookup or signing.

Test plan

  • git diff --check
  • IDE linter diagnostics are clean
  • Run targeted Express tests in CI; local Yarn/Mocha execution is unavailable because the checkout lacks Yarn and a workspace Mocha binary.

PT-000000

@mmcshinsky-bitgo
mmcshinsky-bitgo force-pushed the pt-000000-express-wallet-binding branch from ceed19a to 71eb783 Compare August 4, 2026 22:27
@mmcshinsky-bitgo mmcshinsky-bitgo changed the title PT-000000: Bind Express wallet signing to route identity Bind Express wallet signing to route identity Aug 4, 2026
mmcshinsky-bitgo added a commit that referenced this pull request Aug 4, 2026
Reject mismatched prebuild wallet IDs before wallet lookup or signing on
wallet and TSS wallet transaction routes.

Co-authored-by: Cursor <cursoragent@cursor.com>

#9419
@mmcshinsky-bitgo
mmcshinsky-bitgo force-pushed the pt-000000-express-wallet-binding branch 2 times, most recently from 0f817f2 to fafecda Compare August 4, 2026 22:38
Reject mismatched prebuild wallet IDs before wallet lookup or signing on
wallet and TSS wallet transaction routes.

#9419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant