feat(sdk-core): always upgrade to v2 on password change - #9416
Open
pranavjain97 wants to merge 2 commits into
Open
feat(sdk-core): always upgrade to v2 on password change#9416pranavjain97 wants to merge 2 commits into
pranavjain97 wants to merge 2 commits into
Conversation
Contributor
updateSingleKeychainPassword now always re-encrypts as v2 (Argon2id), regardless of the source envelope version. A password change is a natural upgrade point, so v1 (SJCL) keychains are transparently promoted; v2 stays v2. TICKET: WCN-1814
pranavjain97
force-pushed
the
pranavjain/wcn-1814-switch-to-argon2-on-password-change
branch
from
August 4, 2026 18:57
fb2ce33 to
f12d8da
Compare
Parameterize updateSingleKeychainPassword/updatePassword with an optional encryptionVersion. Default stays at v2 (from the previous commit), so callers get the Argon2 upgrade for free. Callers that still need v1 output (the UI until the Sept 15 breaking-change window closes) opt out with encryptionVersion: 1. TICKET: WCN-1814
davidkaplanbitgo
approved these changes
Aug 5, 2026
davidkaplanbitgo
left a comment
davidkaplanbitgo
left a comment
Contributor
There was a problem hiding this comment.
CI failures but LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flip
updateSingleKeychainPasswordfrom preserving the source envelope version to always re-encrypting as v2 (Argon2id + AES-256-GCM). A password change is a natural upgrade point — v1 (SJCL) keychainsare transparently promoted; v2 stays v2.
Impact
TICKET: WCN-1814