feat(ActiveJob): honor scheduled_at as the default run_at - #121
Open
smudge wants to merge 1 commit into
Open
Conversation
When a JobWrapper is built from previously-serialized job data (e.g. via `retry_on` or `retry_job`), the wrapped job's scheduled_at was ignored and the job would run immediately. The preparer now falls back to the payload's scheduled_at before defaulting to now. (This only applies to ActiveJobs, and an explicit :run_at option still wins.) stack-info: PR: #121, branch: smudge/stack/4
This was referenced Aug 4, 2026
smudge
marked this pull request as draft
August 4, 2026 23:14
smudge
marked this pull request as ready for review
August 4, 2026 23:14
samandmoore
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
feat(ActiveJob): honor scheduled_at as the default run_at
When a JobWrapper is built from previously-serialized job data (e.g. via
retry_onorretry_job), the wrapped job's scheduled_at was ignored and the job would run immediately.The preparer now falls back to the payload's scheduled_at before defaulting to now.
(This only applies to ActiveJobs, and an explicit :run_at option still wins.)