New Release 1.25.2#536
Merged
Merged
Conversation
…ca2dcd1 ci: bump pinned publish-platforms.yml to ca2dcd1
#534) Jobs Reborn awards block-break rewards from a BlockBreakEvent handler at EventPriority.HIGHEST with ignoreCancelled=true. AOneBlock also only checked the MAGIC_BLOCK protection flag (and cancelled the break) at HIGHEST. Within a single priority slot, Bukkit fires handlers in plugin-registration order, which is nondeterministic. When Jobs ran before AOneBlock, it paid out before the break was cancelled; since the magic block respawns on a cancelled break, a player lacking the MAGIC_BLOCK flag could mine it endlessly for infinite rewards. Add a dedicated onBlockBreakDeny handler at EventPriority.LOWEST that runs the MAGIC_BLOCK flag check (which cancels the event on denial). Cancelling at LOWEST is strictly before any later ignoreCancelled=true handler, so reward plugins are skipped for denied breaks. Full magic-block processing stays at HIGHEST, and allowed breaks are unaffected. Bump version to 1.25.2. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017nxjWg93etdoy6U6nhTXRX
…d S8924) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017nxjWg93etdoy6U6nhTXRX
…ity-534 fix: cancel denied magic-block break early to stop Jobs reward exploit (#534)
The BossBarListener is registered into Bukkit by BentoBox's FlagsManager whenever the ONEBLOCK_BOSSBAR or ONEBLOCK_ACTIONBAR flag is registered. With actionbar: false and bossbar: true in config.yml, the listener was still active via the boss bar flag, and tryToShowActionBar only checked the island flag - which defaults to allowed even when unregistered - so the action bar showed despite being disabled. Guard both tryToShowActionBar and tryToShowBossBar with their config settings, and remove the explicit registerListener(bossBar) call in onEnable which duplicated the FlagsManager registration and caused the handlers to fire twice per event when both settings were enabled. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012eC7vj7ghNGSNGpxqQazxm
…red-537 fix: respect actionbar/bossbar config settings in BossBarListener
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.