Skip to content

Workflows/ci hygiene - #609

Open
MaddyMicrosoft wants to merge 6 commits into
masterfrom
workflows/ci-hygiene
Open

Workflows/ci hygiene#609
MaddyMicrosoft wants to merge 6 commits into
masterfrom
workflows/ci-hygiene

Conversation

@MaddyMicrosoft

@MaddyMicrosoft MaddyMicrosoft commented Aug 14, 2026

Copy link
Copy Markdown
Member

Summary

Cleanup of the Azure Login CI/test workflows: removes dead/redundant config, refreshes a stale action pin, and stops running live-credential tests on every push.

Changes

  • Bump azure/login@ v1 to v3 in the canary and integration tests — these scheduled tests were validating a two-major-old release. They now exercise the current major (v3), so upstream az CLI / Az PowerShell breakage is caught against the version consumers actually use.
  • Remove dead slack job
  • Consolidate pr-check into ci — pr-check.yml duplicated ci.yml's build + test on a single platform (windows-only) and against the raw PR head. ci.yml already runs on master PRs across windows and ubuntu and tests the merge result, so the redundant workflow is deleted. Not a required status check, so this does not affect merges.
  • Run positive/negative live tests on pull requests instead of every push — these suites perform real Azure logins. Triggering on every push to any branch ran the full matrix (and consumed live credentials) for incidental commits. They now run on pull_request targeting master, keeping workflow_dispatch for manual runs — a cost and time saving.
  • Make positive/negative live tests self-provisioning, removes the obsolete VM assertions while still fully validating auth, and adds a shared concurrency group so the two workflows don't collide. Merged into one file to reduce manual approvals

MaddyMicrosoft and others added 4 commits August 13, 2026 07:17
The canary and integration-test workflows still pinned azure/login@v1 while
the action is on v3, so they were validating a two-major-old release instead
of the current one.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The slack-post-result jobs posted to a Slack webhook that is no longer used,
and referenced a secret with broken interpolation. Removing them; the test
jobs themselves are unchanged.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pr-check.yml duplicated ci.yml's build+test (ci.yml already runs on master
PRs across windows and ubuntu). Removing the redundant workflow.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
These suites perform real Azure logins. Triggering on every push to any
branch ran the full matrix (and consumed live credentials) for incidental
commits. Switch to pull_request targeting master, keeping workflow_dispatch
for manual runs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- positive/negative: add setup/teardown jobs that create and delete
  GitHubAction_CI_Group via azure/login@v3 (stable), gated on all jobs
- drop az vm list / Get-AzVM assertions (no VM is provisioned)
- negative permission tests keep targeting the never-created
  GitHubAction_CI_RG so they fail as expected
- shared concurrency group so positive/negative don't collide on the RG
Replace azure-login-positive.yml and azure-login-negative.yml with a
single azure-login-live-tests.yml. All 49 positive and 45 negative test
steps are preserved unchanged; only structure and provisioning change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants