[eno][part1/2] Continue synthesis with incomplete ResourceSlice history - #651
Open
Ruinan Liu (ruinan-liu) wants to merge 3 commits into
Open
[eno][part1/2] Continue synthesis with incomplete ResourceSlice history#651Ruinan Liu (ruinan-liu) wants to merge 3 commits into
Ruinan Liu (ruinan-liu) wants to merge 3 commits into
Conversation
Ruinan Liu (ruinan-liu)
requested review from
Robbie Zhang (robbiezhang),
Tingting Liu (tilnl) and
xiazhan
as code owners
September 10, 2026 21:03
Ruinan Liu (ruinan-liu)
marked this pull request as draft
September 11, 2026 01:13
Ruinan Liu (ruinan-liu)
marked this pull request as ready for review
September 11, 2026 17:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow synthesis to proceed when historical ResourceSlice references are nil, empty, or point to missing objects, instead of blocking on unavailable history.
• Generate desired resources and tombstones using the historical slices that remain available.
• Set TombstoneRecoveryRequired when history is incomplete or no current synthesis exists, and carry the flag forward across subsequent syntheses.
• Allow reconstitution to skip unavailable previous history while preserving strict loading of current desired resources and existing handling of non-404 API errors.
• Handle malformed references safely in resynthesis requests, cleanup, and not-ready diagnostics.
• Include the recovery flag in the Composition CRD schema.
This is Part 1 only: the flag does not block synthesis or reconciliation. Recovering deletions from unavailable history and clearing the flag are deferred to a later change.
Testing
Added 36 test groups with 170 subtests covering unit, executor-functional, and envtest controller-integration scenarios. All new tests pass, including race checks.