Skip to content

Allow TestFigSpec snapshot updates without ext-registry core review - #9377

Merged
JeffreyCA merged 4 commits into
mainfrom
copilot/ext-registry-check-relaxation
Jul 31, 2026
Merged

Allow TestFigSpec snapshot updates without ext-registry core review#9377
JeffreyCA merged 4 commits into
mainfrom
copilot/ext-registry-check-relaxation

Conversation

Copilot AI commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Simple extension registry PRs often need a companion TestFigSpec.ts snapshot update when registry-backed commands change. The core-review gate treated that file as out-of-scope and blocked the PR.

The problem

ext-registry-check only allowed edits to registry.json / registry.dev.json on the no-core-review path. Any other changed file failed with:

PR changes files outside the extension registries (...), which requires core review:
cli/azd/cmd/testdata/TestFigSpec.ts

Change

  • Allowlist cli/azd/cmd/testdata/TestFigSpec.ts as a companion non-registry path in diffChangedFiles
  • Keep requiring core review for any other non-registry file
  • Cover both paths in unit tests

Behavior at a glance

PR files Core review required?
Registry only (simple bump) No
Registry + TestFigSpec.ts No (new)
Registry + TestFigSpec.ts + anything else Yes

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
20 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@JeffreyCA
JeffreyCA marked this pull request as ready for review July 30, 2026 22:25
Copilot AI review requested due to automatic review settings July 30, 2026 22:25
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
22 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Not ready to approve

The allowlist also exempts snapshot deletions and renames from core review.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

Allows generated FigSpec snapshots to accompany simple extension registry updates without core review.

Changes:

  • Allowlist TestFigSpec.ts.
  • Add positive and negative policy tests.
File summaries
File Description
.github/scripts/src/ext-registry-check.js Adds the snapshot-path exception.
.github/scripts/test/ext-registry-check.test.js Tests allowed and disallowed companion changes.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Balanced

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

Comment thread .github/scripts/src/ext-registry-check.js Outdated
Copilot AI requested review from Copilot and removed request for Copilot July 30, 2026 22:37
Copilot AI requested a review from JeffreyCA July 30, 2026 22:39
@JeffreyCA
JeffreyCA requested a review from Copilot July 30, 2026 22:45
@github-actions

Copy link
Copy Markdown

🔗 Linked Issue Required

Thanks for the contribution! Please link a GitHub issue to this PR by adding Fixes #123 to the description or using the sidebar.
No issue yet? Feel free to create one!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Not ready to approve

Dev-registry-only PRs can bypass review without triggering snapshot validation.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Balanced

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

Comment thread .github/scripts/src/ext-registry-check.js Outdated
@JeffreyCA JeffreyCA added the skip-governance Skip PR governance checks label Jul 30, 2026
Copilot AI and others added 3 commits July 31, 2026 16:10
Co-authored-by: JeffreyCA <9157833+JeffreyCA@users.noreply.github.com>
Co-authored-by: JeffreyCA <9157833+JeffreyCA@users.noreply.github.com>
Co-authored-by: JeffreyCA <9157833+JeffreyCA@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 31, 2026 16:18
@JeffreyCA
JeffreyCA force-pushed the copilot/ext-registry-check-relaxation branch from fb50757 to 1cf2d53 Compare July 31, 2026 16:18
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 0d2346bc-62fd-4ee5-87aa-f7e6ce79497f

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Ready to approve

The implementation matches the stated behavior and covers the relevant edge cases.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

Copilot AI requested review from Copilot and removed request for Copilot July 31, 2026 16:20
@JeffreyCA
JeffreyCA enabled auto-merge (squash) July 31, 2026 17:38
@JeffreyCA

Copy link
Copy Markdown
Contributor

/check-enforcer override

@JeffreyCA
JeffreyCA merged commit adce59c into main Jul 31, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-governance Skip PR governance checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants