Allow TestFigSpec snapshot updates without ext-registry core review - #9377
Conversation
|
Azure Pipelines: 20 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: 22 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
🟡 Not ready to approve
The allowlist also exempts snapshot deletions and renames from core review.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Allows generated FigSpec snapshots to accompany simple extension registry updates without core review.
Changes:
- Allowlist
TestFigSpec.ts. - Add positive and negative policy tests.
File summaries
| File | Description |
|---|---|
.github/scripts/src/ext-registry-check.js |
Adds the snapshot-path exception. |
.github/scripts/test/ext-registry-check.test.js |
Tests allowed and disallowed companion changes. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
🔗 Linked Issue RequiredThanks for the contribution! Please link a GitHub issue to this PR by adding |
There was a problem hiding this comment.
🟡 Not ready to approve
Dev-registry-only PRs can bypass review without triggering snapshot validation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Co-authored-by: JeffreyCA <9157833+JeffreyCA@users.noreply.github.com>
Co-authored-by: JeffreyCA <9157833+JeffreyCA@users.noreply.github.com>
Co-authored-by: JeffreyCA <9157833+JeffreyCA@users.noreply.github.com>
fb50757 to
1cf2d53
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0d2346bc-62fd-4ee5-87aa-f7e6ce79497f
There was a problem hiding this comment.
🟢 Ready to approve
The implementation matches the stated behavior and covers the relevant edge cases.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
|
/check-enforcer override |
Summary
Simple extension registry PRs often need a companion
TestFigSpec.tssnapshot update when registry-backed commands change. The core-review gate treated that file as out-of-scope and blocked the PR.The problem
ext-registry-checkonly allowed edits toregistry.json/registry.dev.jsonon the no-core-review path. Any other changed file failed with:Change
cli/azd/cmd/testdata/TestFigSpec.tsas a companion non-registry path indiffChangedFilesBehavior at a glance
TestFigSpec.tsTestFigSpec.ts+ anything else