Add quoting examples for containerapp secret set with special characters - #34093
Open
Alabi Toluwaleke (fvlga) wants to merge 1 commit into
Open
Alabi Toluwaleke (fvlga) wants to merge 1 commit into
Alabi Toluwaleke (fvlga) wants to merge 1 commit into
Conversation
Alabi Toluwaleke (fvlga)
requested review from
a team,
Greedygre (Greedygre),
Zunli Hu (Juliehzl) and
Hong Wang (howang-ms)
as code owners
September 16, 2026 21:27
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
requested review from
Yu Chen (jsntcy),
ZelinWang (wangzelin007),
Julie Zhu (yanzhudd) and
Yong Zhang (yonzhan)
September 16, 2026 21:28
microsoft-github-policy-service
Bot
added
the
customer-reported
Contributor
|
Thank you for your contribution Alabi Toluwaleke (@fvlga)! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
Bot
added
Auto-Assign
Copilot started reviewing on behalf of
Alabi Toluwaleke (fvlga)
September 16, 2026 21:28
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
Pull request overview
Adds shell-quoting examples for az containerapp secret set values containing special characters.
Changes:
- Added single-quoted example for spaces and punctuation.
- Added double-quoted example for apostrophes.
File summaries
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/containerapp/_help.py |
Extends secret-setting help examples. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
containerapp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az containerapp secret set
Description
Addressing #32658.
The examples for
az containerapp secret setonly showed a trivial secret value, with no guidance on handling values that contain spaces, colons, semicolons, double quotes, or apostrophes — characters commonly found in connection strings and generated passwords. This adds two new examples:key=valuepair should be single-quoted.key=valuepair avoids needing to escape the apostrophe.A previous attempt at this (#32720) was opened and closed without merging; this addresses the same issue.
Testing Guide
Ran
python -m py_compileon the modified_help.pyto confirm it's still valid Python, and confirmedaz containerapp secret set --helprenders both new examples correctly. No functional change — help text only.History Notes
N/A
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.