Skip to content

[Network] Reverting NVA Migration PR - #34092

Open
Graves (Jordang3177) wants to merge 1 commit into
Azure:devfrom
Jordang3177:Reverting_Migration_API_PR
Open

Graves (Jordang3177) wants to merge 1 commit into
Azure:devfrom
Jordang3177:Reverting_Migration_API_PR

Conversation

@Jordang3177

@Jordang3177 Graves (Jordang3177) commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

🤖 PR Validation — ❌ Action needed

Breaking Changes Tests
❌ 1 ️✔️ 130/130
❌AzureCLI-BreakingChangeTest
❌network
rule cmd_name rule_message suggest_message
1012 - SubgroupRemove network virtual-appliance migration sub group network virtual-appliance migration removed please confirm sub group network virtual-appliance migration removed

Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:

  • Breaking changes can only be merged during the designated breaking change window
  • A pre-announcement must be released at least one month in advance

For more details on how to introduce breaking changes, refer to the documentation: azure-cli/doc/how_to_introduce_breaking_changes.md

Related command

az network virtual-appliance migration prepare
az network virtual-appliance migration execute
az network virtual-appliance migration commit
az network virtual-appliance migration abort

Description

Reverts #33766.

This removes the az network virtual-appliance migration command group and its prepare, execute, commit, and abort commands. The commands are being removed while the supporting service contract and AAZ definitions are finalized.

The generated AAZ command files and associated live scenario test are removed. Other Network Virtual Appliance commands are unaffected.

Testing Guide

Verify that the migration command group is no longer registered:

az network virtual-appliance migration --help

The command should report that migration is not recognized.

Run the Network module unit tests:

python -m unittest azure.cli.command_modules.network.tests.latest.test_network_unit_tests

Expected result: all tests pass.

History Notes

[Network] BREAKING CHANGE: az network virtual-appliance migration: Remove the NVA migration command group


This checklist is used to make sure that common guidelines for a pull request are followed.

Copilot AI lite review requested due to automatic review settings September 16, 2026 20:58
@Jordang3177
Graves (Jordang3177) requested a review from a team as a code owner September 16, 2026 20:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a focused reversion, and the sole finding is a non-blocking changelog nit.

Pull request overview

Reverts the unfinished NVA migration command group pending finalized service contracts and AAZ definitions.

Changes:

  • Removes the prepare, execute, commit, and abort commands.
  • Removes migration registration and package exports.
  • Removes the associated live scenario test.
File summaries
File Reviewed change
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py Removes the migration scenario test.
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/virtual_appliance/migration/_prepare.py Removes the prepare command.
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/virtual_appliance/migration/_execute.py Removes the execute command.
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/virtual_appliance/migration/_commit.py Removes the commit command.
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/virtual_appliance/migration/_abort.py Removes the abort command.
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/virtual_appliance/migration/__init__.py Removes migration package exports.
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/virtual_appliance/migration/__cmd_group.py Removes migration registration. The unreleased changelog entry should also be updated to avoid advertising the removed commands.
Review details

Suppressed comments (1)

src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/virtual_appliance/migration/__cmd_group.py:1

  • This removes the command registration but leaves src/azure-cli/HISTORY.rst:199 advertising az network virtual-appliance migration as supported in the unreleased 2.90.0 notes. Please remove or replace that entry with the breaking-change removal note so the changelog does not direct users to a command that now returns “not recognized”.
  • Files reviewed: 7/7 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@yonzhan

Copy link
Copy Markdown
Collaborator

network

@Jordang3177 Graves (Jordang3177) changed the title Reverting NVA Migration PR [Network] Reverting NVA Migration PR Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants