[Network] Reverting NVA Migration PR - #34092
Open
Graves (Jordang3177) wants to merge 1 commit into
Open
Graves (Jordang3177) wants to merge 1 commit into
Graves (Jordang3177) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a focused reversion, and the sole finding is a non-blocking changelog nit.
Pull request overview
Reverts the unfinished NVA migration command group pending finalized service contracts and AAZ definitions.
Changes:
- Removes the
prepare,execute,commit, andabortcommands. - Removes migration registration and package exports.
- Removes the associated live scenario test.
File summaries
| File | Reviewed change |
|---|---|
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py |
Removes the migration scenario test. |
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/virtual_appliance/migration/_prepare.py |
Removes the prepare command. |
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/virtual_appliance/migration/_execute.py |
Removes the execute command. |
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/virtual_appliance/migration/_commit.py |
Removes the commit command. |
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/virtual_appliance/migration/_abort.py |
Removes the abort command. |
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/virtual_appliance/migration/__init__.py |
Removes migration package exports. |
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/virtual_appliance/migration/__cmd_group.py |
Removes migration registration. The unreleased changelog entry should also be updated to avoid advertising the removed commands. |
Review details
Suppressed comments (1)
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/virtual_appliance/migration/__cmd_group.py:1
- This removes the command registration but leaves
src/azure-cli/HISTORY.rst:199advertisingaz network virtual-appliance migrationas supported in the unreleased 2.90.0 notes. Please remove or replace that entry with the breaking-change removal note so the changelog does not direct users to a command that now returns “not recognized”.
- Files reviewed: 7/7 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
network |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ❌ Action needed
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
Related command
az network virtual-appliance migration prepareaz network virtual-appliance migration executeaz network virtual-appliance migration commitaz network virtual-appliance migration abortDescription
Reverts #33766.
This removes the
az network virtual-appliance migrationcommand group and itsprepare,execute,commit, andabortcommands. The commands are being removed while the supporting service contract and AAZ definitions are finalized.The generated AAZ command files and associated live scenario test are removed. Other Network Virtual Appliance commands are unaffected.
Testing Guide
Verify that the migration command group is no longer registered:
The command should report that
migrationis not recognized.Run the Network module unit tests:
Expected result: all tests pass.
History Notes
[Network] BREAKING CHANGE:
az network virtual-appliance migration: Remove the NVA migration command groupThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.