[Network] az network application-gateway ssl-profile add/update: Expose client authentication mode - #34090
Open
spalabatla26 wants to merge 1 commit into
Open
[Network] az network application-gateway ssl-profile add/update: Expose client authentication mode#34090spalabatla26 wants to merge 1 commit into
az network application-gateway ssl-profile add/update: Expose client authentication mode#34090spalabatla26 wants to merge 1 commit into
Conversation
…n mode Expose the generated auth-configuration argument through handwritten add/update wrappers and render Passthrough help examples. Extend and re-record the SSL-profile scenario for Passthrough and Strict with compatible TLS policies. Validation: live scenario passed (721.45s); offline replay passed (482.52s); azdev linter network, azdev style network, and git diff --check passed. Runtime help and four generated PUT serialization checks passed. Temporary Azure test resource group deletion completed.
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
requested review from
Yu Chen (jsntcy),
Ethan Yang (necusjz) and
Yong Zhang (yonzhan)
September 16, 2026 18:07
Contributor
|
Thank you for your contribution spalabatla26! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified, and validation covers the updated commands.
Pull request overview
This PR exposes mTLS client-authentication modes for application gateway SSL-profile commands.
Changes:
- Registers
--auth-configurationfor add/update. - Adds Passthrough documentation and history.
- Extends scenario coverage for Passthrough/Strict transitions.
File summaries
| File | Summary |
|---|---|
src/azure-cli/HISTORY.rst |
Documents the feature. |
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py |
Tests authentication-mode transitions. |
src/azure-cli/azure/cli/command_modules/network/custom.py |
Exposes authentication configuration arguments. |
src/azure-cli/azure/cli/command_modules/network/_help.py |
Adds Passthrough help examples. |
Review details
- Files reviewed: 4/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Collaborator
|
Please fix CI issues |
az network application-gateway ssl-profile add/update: Expose client authentication mode
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
| * `az network public-ip create/update`: Add `--ddos-custom-policy` to attach a DDoS custom policy (#33812) | ||
| * `az network application-gateway waf-policy managed-rule rule-set update`: Allow updating rule group without rule IDs (#33871) | ||
| * `az network private-endpoint-connection`: Add provider `Microsoft.HardwareSecurityModules/paymentHsmClusters` (#33889) | ||
| * `az network application-gateway ssl-profile add/update`: Expose `--auth-configuration` to support mTLS `verify-client-auth-mode=Passthrough|Strict` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation —⚠️ Review suggested
Related command
az network application-gateway ssl-profile addaz network application-gateway ssl-profile updateDescription
Expose the existing generated
--auth-configurationobject argument through the handwritten SSL-profile add/update wrappers so users can setverify-client-auth-mode=Passthrough|Strict.The AAZ-generated commands already define the enum and serialize
verify_client_auth_modetoproperties.clientAuthConfiguration.verifyClientAuthModein API2025-07-01. However, both handwritten wrappers marked the object argument as unregistered. This change removes those two statements while preserving the existing Boolean client-authentication aliases.AZ_HELPoverrides. The overrides are needed because the generated command help takes precedence at runtime.aaz/files were hand-edited and no recording responses were fabricated.AppGwSslPolicy20170401Son the first update. The legacy gateway-create path and newer update API otherwise use incompatible default policy families. This affects only test setup, not production command defaults.Testing Guide
Run from an activated Azure CLI development environment:
The live command creates billable temporary Azure resources and requires an appropriate test subscription. The replay command omits
--liveand uses the committed recording.Observed validation results
1 passed, 368 deselected in 721.45s (0:12:01); exit 01 passed, 368 deselected in 482.52s (0:08:02)Linter: PASSED; no CLI or custom pylint rule violationsPylint: PASSED,Flake8: PASSEDgit diff --checkpassed--auth-configurationand rejectBoguswith allowed valuesPassthroughandStrict2025-07-01; zero HTTP callsReviewable evidence
The cassette contains 99 HTTP interactions. A structured scan found
verifyClientAuthModein requests (Strict: 14, Passthrough: 2) and responses (Strict: 54, Passthrough: 7). Counts include existing profiles and repeated polling responses; they are not counts of independent test cases. The actual test subscription ID, user email, andBearermarker were absent in the checks performed.Temporary scenario resource-group deletion was confirmed complete. The previous default subscription was restored. The separate smoke-test profile was removed and its gateway returned to
Succeededwith no SSL profiles.Validation scope and caveats
azwas missing from PATH. Replay passed after activating the virtualenv.History Notes
[Network]
az network application-gateway ssl-profile add/update: Expose--auth-configurationto support mTLSverify-client-auth-mode=Passthrough|Strict