{Compute} az vmss/vm: Update Open Capacity Reservation validation to support 'None'

[William (william051200)]

🤖 PR Validation — ️✔️ All clear

Breaking Changes	Tests
️✔️ None	️✔️ 130/130

Related command

az vm create/update
az vmss create/update

Description

Update the command to support None as input, eg:
capacity reservation group is None + disable capacity reservation group is True = Allowed

Testing Guide

History Notes

---

This checklist is used to make sure that common guidelines for a pull request are followed.

• The PR title and description has followed the guideline in Submitting Pull Requests.

• I adhere to the Command Guidelines.

• I adhere to the Error Handling Guidelines.

[Copilot]

🟡 Changes recommended

The VM update path must omit the capacity reservation group when None is used with disabled assignment.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Updates VM and VMSS capacity reservation validation and payload construction to support None when assignment is disabled.

Changes:

• Relaxes validation for the None sentinel.
• Centralizes capacity reservation profile construction.
• Omits capacity reservation groups when appropriate.

File summaries

File	Summary and review findings
src/azure-cli/azure/cli/command_modules/vm/_validators.py	Updates validation rules. Missing command-level regression coverage (nit, 1 vote). VM update still emits an empty capacity reservation group for None with disabled assignment (moderate, 1 vote).
src/azure-cli/azure/cli/command_modules/vm/_template_builder.py	Adds shared profile construction. Missing focused unit coverage for sentinel, boolean, and omitted-value cases (nit, 3 votes).

Review details

Suppressed comments (2)

src/azure-cli/azure/cli/command_modules/vm/_validators.py:2836

• This changes the acceptance rule for all four create/update commands, but the repository has no regression test for the newly allowed combination (--capacity-reservation-group None with --disable-capacity-reservation-assignment true) or for rejecting a real group with the flag. The existing open-capacity scenario only exercises the flag without the group. Please add command-level coverage for both the accepted sentinel case and the still-invalid real-group case.

    if (namespace.disable_capacity_reservation_assignment is True and
            namespace.capacity_reservation_group is not None and
            namespace.capacity_reservation_group != 'None'):

src/azure-cli/azure/cli/command_modules/vm/_validators.py:2836

• This newly permits vm update --capacity-reservation-group None --disable-capacity-reservation-assignment true, but the VM update path still converts None into capacity_reservation_group: {"id": None} and does not remove that field (the VMSS update path does). The generated PUT therefore contains an empty capacityReservationGroup alongside disableCapacityReservationAssignment=true, so the advertised combination can still be rejected by Compute. Mirror the VMSS cleanup so the group object is omitted when disable is true.

    if (namespace.disable_capacity_reservation_assignment is True and
            namespace.capacity_reservation_group is not None and
            namespace.capacity_reservation_group != 'None'):

• Files reviewed: 2/2 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Yong Zhang (yonzhan)]

Compute