fix: TxEffect deserializability (forward port of #25109 to next)

[AztecBot]

Forward port of #25109 (358245cb5f65a92d6dab11b8bf4c2eb059bedde8, merged into merge-train/fairies-v5) onto next. The automated port-to-next job failed on this PR; this is the manual port.

Why the auto-port failed

A file-location conflict from the noir-projects directory split — not a content conflict. There are no <<<<<<< markers anywhere in this branch.

#25109 was cut against merge-train/fairies-v5, which predates #25007 ("refactor: split noir-projects into fnd/ and labs/", c2ca1208981) on next. That refactor moved:

• noir-projects/noir-protocol-circuits/** → noir-projects/fnd/noir-protocol-circuits/**
• noir-projects/noir-contracts/** → noir-projects/labs/noir-contracts/**

Rename detection handles the two files #25109 edits — it relocated and cleanly merged .../types/src/blob_data/tx_effect.nr into fnd/ and the test contract's main.nr into labs/. But #25109 also adds a new file, src/test.nr, inside a directory that was renamed on next. Git will not infer a new home for an added file:

CONFLICT (file location): noir-projects/noir-contracts/contracts/test/tx_effect_oracle_test_contract/src/test.nr
added in 358245cb5f6 (fix: TxEffect deserializability (#25109)) inside a directory that was renamed in HEAD,
suggesting it should perhaps be moved to
noir-projects/labs/noir-contracts/contracts/test/tx_effect_oracle_test_contract/src/test.nr.

The porter treats any non-clean cherry-pick as a failure and stops. That one added file is the entire reason.

The two commits

1. chore(port): RAW cherry-pick — the cherry-pick output with the conflict left unresolved: the two edited files merged into their post-refactor: split noir-projects into fnd/ and labs/ #25007 homes, and the added test.nr sitting at its original source path under noir-projects/noir-contracts/..., a directory that no longer exists on next. This commit intentionally does not build.
2. fix(port): … — mechanical — the resolution: git mv of that one file into noir-projects/labs/..., exactly the destination git suggested and where the sibling main.nr that its mod test; belongs to already lives. Pure rename, zero content change.

Where the judgment lives

Decision	Ratified by
(none)	The port contains no decisions. The only hand action is the file move, script-verifiable as byte-identical to the source blob.

Nothing was hand-written or adapted. Every API the ported code uses already exists on next under the labs/ paths:

Used by the port	On next
aztec::ephemeral::EphemeralArray	noir-projects/labs/aztec-nr/aztec/src/ephemeral/mod.nr
oracle::message_processing::get_tx_effects	noir-projects/labs/aztec-nr/aztec/src/oracle/message_processing.nr:71
test::helpers::txe_oracles::get_last_tx_effects	noir-projects/labs/aztec-nr/aztec/src/test/helpers/txe_oracles.nr:160
Deserialize trait	noir-projects/fnd/noir-protocol-circuits/crates/serde/src/serialization.nr:159

Verification

The moved file is byte-identical to the source PR (empty output):

git diff 358245cb5f6:noir-projects/noir-contracts/contracts/test/tx_effect_oracle_test_contract/src/test.nr \
         HEAD:noir-projects/labs/noir-contracts/contracts/test/tx_effect_oracle_test_contract/src/test.nr

The final tree vs next is exactly the source PR's diff — 3 files, +40 / −4, matching 358245cb5f6's own diffstat.

Not validated by a local build; relying on CI.

---

Created by claudebox · group: slackbot · requested by martin · Slack thread