Align allowance admission with liquidation threshold#613
Open
KillariDev wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Boundary semantics
Allowance admission now requires:
repBacking * PRICE_PRECISION >= allowance * securityMultiplier * repEthPriceLiquidation keeps the strict inverse
>comparison, so equality is admissible and non-liquidatable. Later REP withdrawals and escalation deposits intentionally retain their face-value coverage checks.Validation
bun run tscbun run format:checkbun run checkbun run docs:checkbun run knipbun run check:generated-cleangit diff --checkFinal independent review: 93/100, no findings. Final visual review: 89/100, no findings.
Visual evidence
Documentation was checked at 1440x900 and 390x844. The UI change preserves the existing visible Max control and changes its calculated value plus accessible name only. A live UI screenshot could not be attached because the collaborative preview required authentication and the fallback simulation capture hung; focused DOM tests and production Chromium scenarios passed.