Skip to content

fix: read WebUI versions from the served asset directory - #10156

Merged
Soulter merged 1 commit into
AstrBotDevs:masterfrom
wcqqq1214:fix/webui-version-path
Sep 21, 2026
Merged

Soulter merged 1 commit into
AstrBotDevs:masterfrom
wcqqq1214:fix/webui-version-path

Conversation

@wcqqq1214

@wcqqq1214 wcqqq1214 commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

With --webui-dir dashboard/dist, version queries and update checks can read stale data/dist assets and falsely report a WebUI update.

Modifications

  • Read WebUI versions from the served directory across public/authenticated queries and update checks.

  • Preserve default lookup when no directory is configured; return null if the served directory has no version marker, without borrowing another directory's version.

  • Keep existing update comparison behavior.

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results

  • Verified matching/mismatching versions, missing markers, and default lookup through both API families and authentication paths.
  • Existing Dashboard, FastAPI, stats, and startup suites: 264 passed. No test files changed.
  • ruff format ., ruff check ., and git diff --check: passed.

Checklist

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”

  • 📚 I checked the affected WebUI instructions and screenshots in docs/zh and docs/en against the changed navigation, page structure, and labels, and updated them in this PR (or explained why no documentation update is needed). For renamed, moved, or merged entry points, I included an old entry → new entry mapping in the documentation and changelog.
    / 我已对照变化后的 WebUI 入口、页面结构和术语,核对并在本 PR 中更新 docs/zhdocs/en 的相关操作说明与截图(或说明无需更新文档的原因)。入口改名、移动或合并时,已在文档和 changelog 中补充 旧入口 → 新入口 对照。

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txtpyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Use the dashboard’s served asset directory as the source of truth for WebUI version reporting and update checks.

Bug Fixes:

  • Read WebUI versions from the directory currently served by the dashboard for authenticated and public version queries and update checks.
  • Return no WebUI version when the configured served directory lacks a version marker instead of falling back to stale assets.

Enhancements:

  • Preserve the existing default version lookup when no served directory is configured while retaining current update comparison behavior.

@wcqqq1214
wcqqq1214 marked this pull request as ready for review September 20, 2026 12:41

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@Soulter
Soulter merged commit 95e98b8 into AstrBotDevs:master Sep 21, 2026
23 checks passed
@wcqqq1214
wcqqq1214 deleted the fix/webui-version-path branch September 21, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants