Skip to content

Fix formatting and type checks for OpenCode asset cache #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pirate merged 2 commits into from
Sep 7, 2026
Merged

Fix formatting and type checks for OpenCode asset cache #70

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84e87c8
Apply repository formatter to OpenCode performance changes
pirate Sep 7, 2026
25070cb
Make static asset cache branches explicit to the type checker
pirate Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 32 additions & 14 deletions abx_plugins/plugins/opencode/runtime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@
_PROXY_PREFIX = "/admin/agent/opencode"
_PROXY_PREFIX_NO_SLASH_REGEX = _PROXY_PREFIX.lstrip("/").replace("/", r"\/")
_CONFIG_PATH = Path(__file__).with_name("config.json")
_DEFAULT_CONFIG = '''{
_DEFAULT_CONFIG = """{
"$schema": "https://opencode.ai/config.json",
"snapshot": false
}
'''
"""

_TEXT_CONTENT_TYPES = (
"text/",
Expand Down Expand Up @@ -621,27 +621,45 @@ def proxy(settings: dict, method: str, path: str, params, headers, body: bytes):
) as upstream:
content = upstream.content
response_headers = _response_headers(upstream, settings)
asset = method == "GET" and path.startswith("assets/") and upstream.status_code == 200
key = (settings["origin"], upstream.headers.get("Content-Type", ""), hashlib.sha256(content).digest()) if asset else None
cached = _ASSETS.get(key)
asset = (
method == "GET"
and path.startswith("assets/")
and upstream.status_code == 200
)
key = (
(
settings["origin"],
upstream.headers.get("Content-Type", ""),
hashlib.sha256(content).digest(),
)
if asset
else None
)
cached = _ASSETS.get(key) if key is not None else None
if cached is not None:
content, etag = cached
content = cached[0]
else:
if any(upstream.headers.get("Content-Type", "").startswith(prefix) for prefix in _TEXT_CONTENT_TYPES):
if any(
upstream.headers.get("Content-Type", "").startswith(prefix)
for prefix in _TEXT_CONTENT_TYPES
):
content = _rewrite_text(content, settings["origin"])
if key is not None:
etag = f'"{hashlib.sha256(content).hexdigest()}"'
cached = content, f'"{hashlib.sha256(content).hexdigest()}"'
# Keep only outputs, not a second copy of each multi-MB input.
if len(_ASSETS) >= 8:
_ASSETS.pop(next(iter(_ASSETS), None), None)
_ASSETS[key] = content, etag
_ASSETS.pop(next(iter(_ASSETS), key), None)
_ASSETS[key] = cached
response_headers["Cache-Control"] = "no-store"
if asset:
if cached is not None:
# Hashed build assets contain no session data. Cache only privately;
# API responses and the HTML entrypoint must always remain fresh.
response_headers["Cache-Control"] = "private, max-age=3600"
response_headers["ETag"] = etag
validators = {tag.strip().removeprefix("W/") for tag in headers.get("If-None-Match", "").split(",")}
if etag in validators or "*" in validators:
response_headers["ETag"] = cached[1]
validators = {
tag.strip().removeprefix("W/")
for tag in headers.get("If-None-Match", "").split(",")
}
if cached[1] in validators or "*" in validators:
return 304, response_headers, b""
return upstream.status_code, response_headers, content
Loading