feat: Add support for deleting partitions with logic operators other than equals#194
Merged
subkanthi merged 2 commits intoJul 21, 2026
Conversation
subkanthi
marked this pull request as ready for review
July 21, 2026 10:07
Collaborator
Author
BEFORE AFTER |
xieandrew
reviewed
Jul 21, 2026
xieandrew
left a comment
Collaborator
There was a problem hiding this comment.
Logic looks good, just a small issue with the example docs
Comment on lines
+40
to
+44
| --partition '[{"name": "tpep_pickup_datetime", "values": ["2024-12-31T23:51:20"]}]' --dry-run=false | ||
|
|
||
| # delete a range of partitions using a comparison operator (default op is equals) | ||
| ice delete nyc.taxis_p_by_day \ | ||
| --partition '[{"name": "tpep_pickup_datetime", "op": "greater_than_or_equal", "values": ["2024-12-31T23:51:20"]}]' --dry-run=false |
Collaborator
There was a problem hiding this comment.
The value of "name" should be "tpep_pickup_datetime_day" instead of "tpep_pickup_datetime" for both delete calls. The logic was changed in an old PR (#94) and these docs weren't updated.
xieandrew
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #193