suppress -Wmissing-field-initializers on GCC/Clang - #253
Merged
adam-ce merged 2 commits intoAug 9, 2026
Merged
Conversation
adam-ce
requested changes
Aug 7, 2026
adam-ce
left a comment
adam-ce
left a comment
Member
There was a problem hiding this comment.
this should go to
renderer/nucleus/CMakeLists.txt
Line 210 in f3fbb81
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s CMake configuration to suppress -Wmissing-field-initializers when building with GCC/Clang-family compilers, aligning the build output with the intended C++ aggregate/designated-initializer semantics described in the PR.
Changes:
- Adds a GCC/Clang conditional compile-option to disable
-Wmissing-field-initializersglobally.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+106
to
+108
| if (CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang") | ||
| add_compile_options(-Wno-missing-field-initializers) | ||
| endif() |
Contributor
Author
done |
adam-ce
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In C++, a designated initializer is still aggregate initialization, so any member you don't name is value-initialized to zero (nextInChain = nullptr, label = {}, etc.) which is the intended default, rather than left uninitialized.