Use PP task name instead of PP task ID when requesting their outputs#2671
Open
knopers8 wants to merge 1 commit into
Open
Use PP task name instead of PP task ID when requesting their outputs#2671knopers8 wants to merge 1 commit into
knopers8 wants to merge 1 commit into
Conversation
When requesting PP task output as a data source, it's ID was used for DataDescription. Meanwhile, PostProcessingDevice::getOutputSpecs uses the task name, which is the general convention in QC. The commit fixes the data source to use task name. I tested the change with the big TPC remote workflow, it works. It seems nothing was relying on the wrong behaviour. Fixes QC-1336.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When requesting PP task output as a data source, it's ID was used for DataDescription. Meanwhile, PostProcessingDevice::getOutputSpecs uses the task name, which is the general convention in QC. The commit fixes the data source to use task name.
I tested the change with the big TPC remote workflow, it works. It seems nothing was relying on the wrong behaviour.
Fixes QC-1336.