[PWGLF] added task and updated data model for resov1#16695
Merged
Conversation
|
O2 linter results: ❌ 4 errors, |
github-actions
Bot
changed the title
prottayCMT
requested review from
HorstMa,
abmodak,
alibuild,
dmallick2,
ercolessi,
fmazzasc,
gbencedi,
lhusova,
maciacco,
mpuccio,
omvazque,
romainschotter,
skundu692 and
smaff92
as code owners
romainschotter
approved these changes
Jun 16, 2026
Collaborator
|
Error while checking build/O2Physics/o2 for 52e2bdc at 2026-06-21 07:10: Full log here. |
mpuccio
approved these changes
Jun 22, 2026
vkucera
reviewed
Jun 22, 2026
Comment on lines
+17
to
+32
| #include "PWGLF/DataModel/LFPhiFlowTables.h" | ||
|
|
||
| #include <CommonConstants/PhysicsConstants.h> | ||
| #include <Framework/AnalysisTask.h> | ||
| #include <Framework/Configurable.h> | ||
| #include <Framework/HistogramRegistry.h> | ||
| #include <Framework/HistogramSpec.h> | ||
| #include <Framework/InitContext.h> | ||
| #include <Framework/OutputObjHeader.h> | ||
| #include <Framework/runDataProcessing.h> | ||
|
|
||
| #include <Math/Vector4D.h> | ||
|
|
||
| #include <cstdint> | ||
| #include <map> | ||
| #include <string> |
Collaborator
There was a problem hiding this comment.
Please fix the list of includes.
vkucera
reviewed
Jun 22, 2026
|
|
||
| const int64_t kPlusId = phiCand.kaonIndex1(); | ||
|
|
||
| if (uniqueKPlus.find(kPlusId) == uniqueKPlus.end()) { |
Collaborator
There was a problem hiding this comment.
Actually, the check is redundant because you can use try_emplace directly.
vkucera
reviewed
Jun 22, 2026
|
|
||
| const int64_t kMinusId = phiCand.kaonIndex2(); | ||
|
|
||
| if (uniqueKMinus.find(kMinusId) == uniqueKMinus.end()) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.