Skip to content

[PWGEM/Dilepton] add createTTP#16673

Merged
dsekihat merged 1 commit into
AliceO2Group:masterfrom
dsekihat:master
Jun 15, 2026
Merged

[PWGEM/Dilepton] add createTTP#16673
dsekihat merged 1 commit into
AliceO2Group:masterfrom
dsekihat:master

Conversation

@dsekihat

Copy link
Copy Markdown
Collaborator

[PWGEM/Dilepton] add createTTP

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 46 errors, ⚠️ 71 warnings, 🔕 0 disabled

@dsekihat dsekihat enabled auto-merge (squash) June 15, 2026 15:50

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@dsekihat dsekihat merged commit 3446861 into AliceO2Group:master Jun 15, 2026
13 of 14 checks passed
@vkucera

vkucera commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

You are supposed to check your includes.

PWGEM/Dilepton/Tasks/createTTP.cxx

PWGEM/Dilepton/Tasks/createTTP.cxx:29:1: warning: included header Qvectors.h is not used directly [misc-include-cleaner]
PWGEM/Dilepton/Tasks/createTTP.cxx:30:1: warning: included header TrackSelectionTables.h is not used directly [misc-include-cleaner]
PWGEM/Dilepton/Tasks/createTTP.cxx:33:1: warning: included header MeanVertexObject.h is not used directly [misc-include-cleaner]
PWGEM/Dilepton/Tasks/createTTP.cxx:38:1: warning: included header ASoAHelpers.h is not used directly [misc-include-cleaner]
PWGEM/Dilepton/Tasks/createTTP.cxx:55:1: warning: included header TString.h is not used directly [misc-include-cleaner]
PWGEM/Dilepton/Tasks/createTTP.cxx:57:1: warning: included header algorithm is not used directly [misc-include-cleaner]
PWGEM/Dilepton/Tasks/createTTP.cxx:61:1: warning: included header iterator is not used directly [misc-include-cleaner]
PWGEM/Dilepton/Tasks/createTTP.cxx:64:1: warning: included header string_view is not used directly [misc-include-cleaner]
PWGEM/Dilepton/Tasks/createTTP.cxx:65:1: warning: included header type_traits is not used directly [misc-include-cleaner]
PWGEM/Dilepton/Tasks/createTTP.cxx:68:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGEM/Dilepton/Tasks/createTTP.cxx:76:8: warning: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init]
PWGEM/Dilepton/Tasks/createTTP.cxx:198:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
PWGEM/Dilepton/Tasks/createTTP.cxx:216:39: warning: use nullptr [modernize-use-nullptr]
PWGEM/Dilepton/Tasks/createTTP.cxx:217:43: warning: use nullptr [modernize-use-nullptr]
PWGEM/Dilepton/Tasks/createTTP.cxx:462:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGEM/Dilepton/Tasks/createTTP.cxx:500:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Tasks/createTTP.cxx:542:159: warning: no header providing "o2::constants::physics::MassElectron" is directly included [misc-include-cleaner]
PWGEM/Dilepton/Tasks/createTTP.cxx:628:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGEM/Dilepton/Tasks/createTTP.cxx:668:28: warning: no header providing "getTrackParCov" is directly included [misc-include-cleaner]

@vkucera

vkucera commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Fix the bugs, please.

PWGEM/Dilepton/Tasks/createTTP.cxx

PWGEM/Dilepton/Tasks/createTTP.cxx:218:9: style: Condition 'grpo' is always false [knownConditionTrueFalse]
PWGEM/Dilepton/Tasks/createTTP.cxx:534:16: style: Local variable 'isPropOK' shadows outer variable [shadowVariable]
PWGEM/Dilepton/Tasks/createTTP.cxx:573:16: style: Local variable 'isPropOK' shadows outer variable [shadowVariable]
PWGEM/Dilepton/Tasks/createTTP.cxx:628:13: style: Variable 'centralities' can be declared as const array [constVariable]

mcoquet642 pushed a commit to AliceMCH/O2Physics that referenced this pull request Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants