Skip to content

[PWGEM/Dilepton] reduce dependencies of skimmerPrimaryElectronSV.cxx#16636

Merged
dsekihat merged 3 commits into
AliceO2Group:masterfrom
dsekihat:master
Jun 12, 2026
Merged

[PWGEM/Dilepton] reduce dependencies of skimmerPrimaryElectronSV.cxx#16636
dsekihat merged 3 commits into
AliceO2Group:masterfrom
dsekihat:master

Conversation

@dsekihat

@dsekihat dsekihat commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

[PWGEM/Dilepton] reduce dependencies of skimmerPrimaryElectronSV.cxx

@github-actions

github-actions Bot commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 50 errors, ⚠️ 98 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Jun 12, 2026
Merged
@github-actions github-actions Bot added the pwgem label Jun 12, 2026
@dsekihat
Merge pull request #105 from alibuild/alibot-cleanup-16636
f4da43a 
Please consider the following formatting changes to AliceO2Group#16636
@dsekihat dsekihat enabled auto-merge (squash) June 12, 2026 11:04
alibuild
alibuild approved these changes Jun 12, 2026
View reviewed changes

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @dsekihat.

@dsekihat dsekihat merged commit 2fc1af6 into AliceO2Group:master Jun 12, 2026
12 of 13 checks passed
vkucera
vkucera reviewed Jun 16, 2026
View reviewed changes
Comment thread PWGEM/Dilepton/TableProducer/skimmerPrimaryElectronSV.cxx
#include "PWGEM/Dilepton/DataModel/dileptonTables.h"
#include "PWGEM/Dilepton/Utils/ElectronModule.h"
#include "PWGLF/DataModel/LFStrangenessTables.h"
// #include "PWGLF/DataModel/LFStrangenessTables.h"

@vkucera vkucera Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do this.

vkucera
vkucera reviewed Jun 16, 2026
View reviewed changes
Comment thread PWGEM/Dilepton/TableProducer/skimmerPrimaryElectronSV.cxx
#include <PID/PIDTOFParamService.h>

#include <Math/Vector4D.h> // IWYU pragma: keep (do not replace with Math/Vector4Dfwd.h)
// #include <Math/Vector4D.h> // IWYU pragma: keep (do not replace with Math/Vector4Dfwd.h)

@vkucera vkucera Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do this.

@vkucera

vkucera commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

PWGEM/Dilepton/TableProducer/skimmerPrimaryElectronSV.cxx

PWGEM/Dilepton/TableProducer/skimmerPrimaryElectronSV.cxx:25:1: warning: included header CcdbApi.h is not used directly [misc-include-cleaner]
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectronSV.cxx:26:1: warning: included header DCAFitterN.h is not used directly [misc-include-cleaner]
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectronSV.cxx:27:1: warning: included header FwdDCAFitterN.h is not used directly [misc-include-cleaner]
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectronSV.cxx:45:1: warning: included header cstdint is not used directly [misc-include-cleaner]
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectronSV.cxx:49:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectronSV.cxx:51:8: warning: constructor does not initialize these fields: ccdb, mTOFResponse [cppcoreguidelines-pro-type-member-init]
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectronSV.cxx:144:43: warning: use nullptr [modernize-use-nullptr]
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectronSV.cxx:145:5: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]

mcoquet642 pushed a commit to AliceMCH/O2Physics that referenced this pull request Jun 30, 2026
@dsekihat @alibuild @mcoquet642
[PWGEM/Dilepton] reduce dependencies of skimmerPrimaryElectronSV.cxx (A…
09e853d 
…liceO2Group#16636)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments
@alibuild alibuild alibuild approved these changes
@mikesas mikesas Awaiting requested review from mikesas mikesas is a code owner
@rbailhac rbailhac Awaiting requested review from rbailhac rbailhac is a code owner
@feisenhu feisenhu Awaiting requested review from feisenhu feisenhu is a code owner
@hscheid hscheid Awaiting requested review from hscheid hscheid is a code owner
@jokonig jokonig Awaiting requested review from jokonig jokonig is a code owner

Assignees

No one assigned

Labels

pwgem

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dsekihat @vkucera @alibuild