Skip to content

[ALICE3] Fix indices bug in otf decayer#16587

Merged
jesgum merged 9 commits into
AliceO2Group:masterfrom
jesgum:otf-decayer-indices
Jun 12, 2026
Merged

[ALICE3] Fix indices bug in otf decayer#16587
jesgum merged 9 commits into
AliceO2Group:masterfrom
jesgum:otf-decayer-indices

Conversation

@jesgum

@jesgum jesgum commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the alice3 label Jun 9, 2026
@github-actions github-actions Bot changed the title Fix indices bug in otf decayer [ALICE3] Fix indices bug in otf decayer Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 2 errors, ⚠️ 0 warnings, 🔕 0 disabled

@jesgum jesgum marked this pull request as ready for review June 12, 2026 14:13
@jesgum

jesgum commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator Author

Indices are now properly mapped between mothers and daughters within all collisions in a dataframe instead of just the first one. Applies for both for particles that already decayed in the generator and for particles decayed in the decayer

@njacazio fyi

@jesgum jesgum enabled auto-merge (squash) June 12, 2026 14:13
alibuild
alibuild previously approved these changes Jun 12, 2026

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @jesgum.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 41354cb at 2026-06-12 16:15:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/ALICE3/TableProducer/OTF/onTheFlyDecayer.cxx:200:9: error: unused variable 'id' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@jesgum jesgum disabled auto-merge June 12, 2026 14:49
@jesgum jesgum enabled auto-merge (squash) June 12, 2026 14:49

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @jesgum.

@jesgum jesgum merged commit 8c0e826 into AliceO2Group:master Jun 12, 2026
13 of 14 checks passed
@jesgum jesgum deleted the otf-decayer-indices branch June 12, 2026 15:14
mcoquet642 pushed a commit to AliceMCH/O2Physics that referenced this pull request Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants