Skip to content

DPL: avoid one allocation per match #15563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ktf wants to merge 1 commit into
base: dev
Choose a base branch
from
+10 −6
Open

DPL: avoid one allocation per match #15563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions Framework/Core/src/DataDescriptorMatcher.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@
#include "Framework/RuntimeError.h"
#include "Headers/DataHeader.h"
#include "Headers/Stack.h"
#include <array>
#include <iostream>
#include <memory_resource>

namespace o2::framework::data_matcher
{
Expand Down Expand Up @@ -202,9 +204,10 @@ bool DataDescriptorMatcher::match(ConcreteDataMatcher const& matcher, VariableCo
dh.dataOrigin = matcher.origin;
dh.dataDescription = matcher.description;
dh.subSpecification = matcher.subSpec;
DataProcessingHeader dph;
dph.startTime = 0;
header::Stack s{dh, dph};
DataProcessingHeader dph{0, 0, 0};
alignas(std::max_align_t) std::array<std::byte, sizeof(header::DataHeader) + sizeof(DataProcessingHeader) + alignof(std::max_align_t)> buffer;
std::pmr::monotonic_buffer_resource resource{buffer.data(), buffer.size(), std::pmr::null_memory_resource()};
header::Stack s{header::Stack::allocator_type{&resource}, dh, dph};

return this->match(reinterpret_cast<char const*>(s.data()), context);
}
Expand All @@ -217,9 +220,10 @@ bool DataDescriptorMatcher::match(ConcreteDataTypeMatcher const& matcher, Variab
dh.dataOrigin = matcher.origin;
dh.dataDescription = matcher.description;
dh.subSpecification = 0;
DataProcessingHeader dph;
dph.startTime = 0;
header::Stack s{dh, dph};
DataProcessingHeader dph{0, 0, 0};
alignas(std::max_align_t) std::array<std::byte, sizeof(header::DataHeader) + sizeof(DataProcessingHeader) + alignof(std::max_align_t)> buffer;
std::pmr::monotonic_buffer_resource resource{buffer.data(), buffer.size(), std::pmr::null_memory_resource()};
header::Stack s{header::Stack::allocator_type{&resource}, dh, dph};

return this->match(reinterpret_cast<char const*>(s.data()), context);
}
Expand Down